From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC94C3A5A3 for ; Thu, 22 Aug 2019 17:23:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AA6D21743 for ; Thu, 22 Aug 2019 17:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494590; bh=jzjytNtnrJ/2ODtaSdZNF8+JKdKysEd0k3SIvqd6KEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=m5QzOPf6kZ+jXkcnRDOu6MMMhvSrawccxtpoYJHww1JXiksaBmtt4f1W9w+X8SZX7 lmqLPR4ghkOBsI0chkn7SOdg6cD6sZxtEHd8BpQd7skL6UWoMB6D83e6d8/k52LjPM bHk97/ae2e0pqvAlRN9ynbiIEIzzkCLM7WgsiMGY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403846AbfHVRXJ (ORCPT ); Thu, 22 Aug 2019 13:23:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:42412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403785AbfHVRXG (ORCPT ); Thu, 22 Aug 2019 13:23:06 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A644121743; Thu, 22 Aug 2019 17:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494585; bh=jzjytNtnrJ/2ODtaSdZNF8+JKdKysEd0k3SIvqd6KEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z4NWQF88pqx/v1Sp6UhNXhyYJFKMDs1+rGEkWnhJcRtNitP/zPvahd6LUA88wVNl9 vk7ju4Bo8QevaY39AYLBKCxrYHyvzPJKqrQ/dLdxcYhMKH9M5YQzrCPIP7qG97coB0 NIZSTwO/QE6kgWe7FceIZ+Us7eGp5NRgovVeWP8g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Takashi Iwai Subject: [PATCH 4.4 37/78] ALSA: hda - Fix a memory leak bug Date: Thu, 22 Aug 2019 10:18:41 -0700 Message-Id: <20190822171833.116637676@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171832.012773482@linuxfoundation.org> References: <20190822171832.012773482@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang commit cfef67f016e4c00a2f423256fc678a6967a9fc09 upstream. In snd_hda_parse_generic_codec(), 'spec' is allocated through kzalloc(). Then, the pin widgets in 'codec' are parsed. However, if the parsing process fails, 'spec' is not deallocated, leading to a memory leak. To fix the above issue, free 'spec' before returning the error. Fixes: 352f7f914ebb ("ALSA: hda - Merge Realtek parser code to generic parser") Signed-off-by: Wenwen Wang Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -5917,7 +5917,7 @@ static int snd_hda_parse_generic_codec(s err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0); if (err < 0) - return err; + goto error; err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg); if (err < 0)