From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABE2C3A5A1 for ; Thu, 22 Aug 2019 17:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02FDB205ED for ; Thu, 22 Aug 2019 17:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495922; bh=c7ZAd2AV/yp4LCIViPLn6jGQ3zJo7OK6ViAB11Kblik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ext6DH51zux0m19dXmSMNAPkfKjz66nXCllsbSR4wmHFfq700Xil9ohkaAKpFfGUm eBmmORA4bYj8Tr6mk9dFZfS6X+5uKVhP3N5fhFdmJg4CXstNimU8UxpInsTV4BaO5V BfQp8qMAzyDHTt+JHT9T58Jfq5FIWR3R6A1Snwcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392940AbfHVRpV (ORCPT ); Thu, 22 Aug 2019 13:45:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:42434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403836AbfHVRXI (ORCPT ); Thu, 22 Aug 2019 13:23:08 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9777233FC; Thu, 22 Aug 2019 17:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494588; bh=c7ZAd2AV/yp4LCIViPLn6jGQ3zJo7OK6ViAB11Kblik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PcNHF/ssluyDw1o2xlOdp6S7zawYSA5HT9UzFvl2rUeHdlmtAov7eU8tKxLyB7zMa M7SJBk+AeMSW4g+GV4e7AC/TXwulXadC9Fpo05EEe3deBmlwPXPPUYzcGs7hhSjlh1 q1VK+eb9o1Z/nHttfq0UQ8qu9vc3+QAswaRnWBhY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Andrey Konovalov , Hillf Danton , Jiri Kosina Subject: [PATCH 4.4 40/78] HID: hiddev: do cleanup in failure of opening a device Date: Thu, 22 Aug 2019 10:18:44 -0700 Message-Id: <20190822171833.201736423@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171832.012773482@linuxfoundation.org> References: <20190822171832.012773482@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hillf Danton commit 6d4472d7bec39917b54e4e80245784ea5d60ce49 upstream. Undo what we did for opening before releasing the memory slice. Reported-by: syzbot Cc: Andrey Konovalov Signed-off-by: Hillf Danton Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/usbhid/hiddev.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -330,6 +330,10 @@ static int hiddev_open(struct inode *ino return 0; bail_unlock: mutex_unlock(&hiddev->existancelock); + + spin_lock_irq(&list->hiddev->list_lock); + list_del(&list->node); + spin_unlock_irq(&list->hiddev->list_lock); bail: file->private_data = NULL; vfree(list);