From: Andi Kleen <ak@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kan.liang@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com
Subject: Re: [PATCH V2] perf/x86: Consider pinned events for group validation
Date: Thu, 22 Aug 2019 11:55:22 -0700 [thread overview]
Message-ID: <20190822185522.GE5447@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1908222029210.1983@nanos.tec.linutronix.de>
On Thu, Aug 22, 2019 at 08:29:46PM +0200, Thomas Gleixner wrote:
> On Thu, 22 Aug 2019, Andi Kleen wrote:
>
> > > + /*
> > > + * Disable interrupts to prevent the events in this CPU's cpuc
> > > + * going away and getting freed.
> > > + */
> > > + local_irq_save(flags);
> >
> > I believe it's also needed to disable preemption. Probably should
> > add a comment, or better an explicit preempt_disable() too.
>
> Preemption is implicit disabled by disabling interrupts.
Yes it is, this is more for documentation.
-Andi
next prev parent reply other threads:[~2019-08-22 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 15:47 [PATCH V2] perf/x86: Consider pinned events for group validation kan.liang
2019-08-22 18:22 ` Andi Kleen
2019-08-22 18:29 ` Thomas Gleixner
2019-08-22 18:55 ` Andi Kleen [this message]
2019-08-23 2:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822185522.GE5447@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox