From: Greg KH <gregkh@linuxfoundation.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
jslaby@suse.com, jay.dolan@accesio.com, hslester96@gmail.com,
je.yen.tam@ni.com, lkp@intel.com, kai.heng.feng@canonical.com,
heikki.krogerus@linux.intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V1 1/1] serial: 8250_pci: Add F81504A series Support
Date: Thu, 22 Aug 2019 14:15:11 -0700 [thread overview]
Message-ID: <20190822211511.GA11893@kroah.com> (raw)
In-Reply-To: <8e052919-b012-ff3f-f108-380d1ce5f7e7@gmail.com>
On Mon, Aug 19, 2019 at 08:49:50AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi,
>
> Andy Shevchenko 於 2019/8/16 下午 07:26 寫道:
> > On Fri, Aug 16, 2019 at 01:27:29PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> > > Fintek F81504A/508A/512A is PCIE to 4/8/12 UARTs device. It's support
> > > IO/MMIO/PCIE conf to access all functions. The old F81504/508/512 is
> > > only support IO.
> >
> > We have 8250_fintek.
> > Isn't it a right place to add these?
> >
>
> The 8250_fintek implements PNP device with id PNP0501.
> Should I also implements PCIe device in this file?
Does it use the same logic? If so, that makes sense, but if you can not
share anything, then no, it does not make sense.
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-22 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 5:27 [PATCH V1 1/1] serial: 8250_pci: Add F81504A series Support Ji-Ze Hong (Peter Hong)
2019-08-16 11:26 ` Andy Shevchenko
2019-08-19 0:49 ` Ji-Ze Hong (Peter Hong)
2019-08-22 21:15 ` Greg KH [this message]
2019-08-23 1:26 ` Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822211511.GA11893@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=hslester96@gmail.com \
--cc=jay.dolan@accesio.com \
--cc=je.yen.tam@ni.com \
--cc=jslaby@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox