From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09832C41514 for ; Fri, 23 Aug 2019 02:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD6FD2070B for ; Fri, 23 Aug 2019 02:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403920AbfHWCxb (ORCPT ); Thu, 22 Aug 2019 22:53:31 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56266 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731416AbfHWCxa (ORCPT ); Thu, 22 Aug 2019 22:53:30 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7N2rI2G031623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2019 22:53:19 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4157C42049E; Thu, 22 Aug 2019 22:53:18 -0400 (EDT) Date: Thu, 22 Aug 2019 22:53:18 -0400 From: "Theodore Y. Ts'o" To: Rakesh Pandit Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio Message-ID: <20190823025318.GB8130@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Rakesh Pandit , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org References: <20190814095406.GA38531@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814095406.GA38531@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 12:54:08PM +0300, Rakesh Pandit wrote: > Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing > first argument. This was introduced in commit ff95ec22cd7f ("ext4: > add warning to ext4_convert_unwritten_extents_endio") and splitting > extents inside endio would trigger it. > > Signed-off-by: Rakesh Pandit Thanks, applied. - Ted