* [PATCH] drm/komeda: Add missing of_node_get() call
@ 2019-08-20 15:16 Mihail Atanassov
2019-08-23 13:43 ` Ayan Halder
0 siblings, 1 reply; 3+ messages in thread
From: Mihail Atanassov @ 2019-08-20 15:16 UTC (permalink / raw)
Cc: Mihail Atanassov, nd, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
komeda_pipeline_destroy has the matching of_node_put().
Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing")
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 0142ee991957..ca64a129c594 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT);
pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1];
- pipe->of_node = np;
+ pipe->of_node = of_node_get(np);
return 0;
}
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/komeda: Add missing of_node_get() call
2019-08-20 15:16 [PATCH] drm/komeda: Add missing of_node_get() call Mihail Atanassov
@ 2019-08-23 13:43 ` Ayan Halder
2019-08-23 14:41 ` Ayan Halder
0 siblings, 1 reply; 3+ messages in thread
From: Ayan Halder @ 2019-08-23 13:43 UTC (permalink / raw)
To: Mihail Atanassov
Cc: David Airlie, Liviu Dudau, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
james qian wang (Arm Technology China), nd
On Tue, Aug 20, 2019 at 03:16:58PM +0000, Mihail Atanassov wrote:
> komeda_pipeline_destroy has the matching of_node_put().
>
> Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 0142ee991957..ca64a129c594 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT);
>
> pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1];
> - pipe->of_node = np;
> + pipe->of_node = of_node_get(np);
>
Good catch.
Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com>
> return 0;
> }
> --
> 2.22.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/komeda: Add missing of_node_get() call
2019-08-23 13:43 ` Ayan Halder
@ 2019-08-23 14:41 ` Ayan Halder
0 siblings, 0 replies; 3+ messages in thread
From: Ayan Halder @ 2019-08-23 14:41 UTC (permalink / raw)
To: Mihail Atanassov
Cc: David Airlie, Liviu Dudau, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
james qian wang (Arm Technology China), nd
On Fri, Aug 23, 2019 at 01:43:49PM +0000, Ayan Halder wrote:
> On Tue, Aug 20, 2019 at 03:16:58PM +0000, Mihail Atanassov wrote:
> > komeda_pipeline_destroy has the matching of_node_put().
> >
> > Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing")
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 0142ee991957..ca64a129c594 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> > of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT);
> >
> > pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1];
> > - pipe->of_node = np;
> > + pipe->of_node = of_node_get(np);
> >
>
> Good catch.
> Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com>
> > return 0;
> > }
> > --
Pushed to drm-misc-fixes - 51a44a28eefd0d4c1addeb23fc5a599ff1787dfd
Apologies, I accidently pushed the gerrit change-id in the commit
message. Surprisingly, "checkpatch.pl --strict" did not catch the issue.
> > 2.22.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-20 15:16 [PATCH] drm/komeda: Add missing of_node_get() call Mihail Atanassov
2019-08-23 13:43 ` Ayan Halder
2019-08-23 14:41 ` Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox