From: Moritz Fischer <mdf@kernel.org>
To: thor.thayer@linux.intel.com
Cc: mdf@kernel.org, richard.gong@intel.com, agust@denx.de,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCHv4 0/3] fpga: altera-cvp: Add Stratix10 Support
Date: Sat, 24 Aug 2019 11:41:46 -0700 [thread overview]
Message-ID: <20190824184146.GA12399@archbox> (raw)
In-Reply-To: <1566247688-26070-1-git-send-email-thor.thayer@linux.intel.com>
Hi Thor,
On Mon, Aug 19, 2019 at 03:48:05PM -0500, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Newer versions (V2) of Altera/Intel FPGAs CvP have different PCI
> Vendor Specific Capability offsets than the older (V1) Altera/FPGAs.
>
> Most of the CvP registers and their bitfields remain the same
> between both the older parts and the newer parts.
>
> This patchset implements changes to discover the Vendor Specific
> Capability offset and then add Stratix10 CvP support.
>
> V2 Changes:
> Remove inline designator from abstraction functions.
> Reverse Christmas Tree format for local variables
> Remove redundant mask from credit calculation
> Add commment for the delay(1) function in wait_for_credit()
>
> V3 Changes
> Return int instead of void for abstraction functions
> Check the return code from read in altera_cvp_chk_error()
> Move reset of current_credit_byte to clear_state().
> Check return codes of read/writes in added functions.
>
> V4 Changes
> Rename delta_credit to space
> Simplify wait for credit do-while loop.
> Change from udelay() to usleep_range()
> Use min() to find length to send
> Remove NULL initialization from private structure
> Use #define for Version1 offsets
> Change current_credit_byte to u32 sent_packets.
> Changes to Kconfig title and description to support Stratix10.
>
> Thor Thayer (3):
> fpga: altera-cvp: Discover Vendor Specific offset
> fpga: altera-cvp: Preparation for V2 parts.
> fpga: altera-cvp: Add Stratix10 (V2) Support
>
> drivers/fpga/Kconfig | 6 +-
> drivers/fpga/altera-cvp.c | 339 ++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 271 insertions(+), 74 deletions(-)
>
> --
> 2.7.4
>
Applied to for-next. If all goes well I'll send it out with next PR.
- Moritz
prev parent reply other threads:[~2019-08-24 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 20:48 [RESEND PATCHv4 0/3] fpga: altera-cvp: Add Stratix10 Support thor.thayer
2019-08-19 20:48 ` [RESEND PATCHv4 1/3] fpga: altera-cvp: Discover Vendor Specific offset thor.thayer
2019-08-19 20:48 ` [RESEND PATCHv4 2/3] fpga: altera-cvp: Preparation for V2 parts thor.thayer
2019-08-19 20:48 ` [RESEND PATCHv4 3/3] fpga: altera-cvp: Add Stratix10 (V2) Support thor.thayer
2019-08-24 18:41 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824184146.GA12399@archbox \
--to=mdf@kernel.org \
--cc=agust@denx.de \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.gong@intel.com \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox