From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Guo <guoyang2@huawei.com>,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance
Date: Sun, 25 Aug 2019 20:47:44 -0400 [thread overview]
Message-ID: <20190826004744.GA27472@mit.edu> (raw)
In-Reply-To: <20190825172803.GA9505@sol.localdomain>
On Sun, Aug 25, 2019 at 10:28:03AM -0700, Eric Biggers wrote:
> This patch is causing the following. Probably because there's no calls to
> percpu_counter_destroy() for the new counters?
Yeah, I noticed this from my test runs last night as well. It looks
like original patch was never tested with CONFIG_HOTPLUG_CPU.
The other problem with this patch is that it initializes
es_stats_cache_hits and es_stats_cache_miesses too late. They will
get used when the journal inode is loaded. This is mostly harmless,
but it's also wrong.
I've dropped this patch from the ext4 git tree.
- Ted
next prev parent reply other threads:[~2019-08-26 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 2:47 [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance Shaokun Zhang
2019-08-25 3:25 ` Theodore Y. Ts'o
2019-08-25 17:28 ` Eric Biggers
2019-08-26 0:47 ` Theodore Y. Ts'o [this message]
2019-08-26 8:24 ` Shaokun Zhang
2019-08-26 15:57 ` Theodore Y. Ts'o
2019-08-27 5:46 ` Shaokun Zhang
2019-08-26 8:12 ` Shaokun Zhang
2019-08-30 3:11 ` [ext4] [confidence: ] 2f7f60cf9f: WARNING:at_lib/list_debug.c:#__list_add_valid kernel test robot
2019-08-30 3:33 ` Shaokun Zhang
2019-08-30 4:37 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826004744.GA27472@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=guoyang2@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox