From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD58C3A5A5 for ; Mon, 26 Aug 2019 08:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 232432087E for ; Mon, 26 Aug 2019 08:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566809889; bh=ez5AMpXp4hS37CQIGBptpEBbS4i7cIzTCUF/dbsOW8o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ChkpRjOjYSbuRIxaFgDT3v9ooxFgSCQkahauIu5wSawSOKDEHDisbHBsfNPJgySF1 qf/EHHiR0WfT1nXEevuUHycK5oHN/G5YVYOFIB+Xfo6wimyzEgVDjjEZ6uOq/7OX7Y 0kgrfNcR8AVWoB704RuCBgFwe+i7/pJoUfcGs/uA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730411AbfHZI6I (ORCPT ); Mon, 26 Aug 2019 04:58:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:35460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729569AbfHZI6H (ORCPT ); Mon, 26 Aug 2019 04:58:07 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F35D206BA; Mon, 26 Aug 2019 08:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566809887; bh=ez5AMpXp4hS37CQIGBptpEBbS4i7cIzTCUF/dbsOW8o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JTFJFNzvqbGu1GaWn44EG7npyuMeTGRz44vcVIdUGGDEEYxg6iCaKofqt10gcr6+y 2mepEkXdkk2ZWCyMxuguTYqQyPyaMZ1rXrpwbCwUM3/0MfQsgkHH7li3dQCo/eihkk dEwc3S6dGHue87itzo8xtEQsz0vn6iPl9aI8NFcs= Date: Mon, 26 Aug 2019 09:58:02 +0100 From: Jonathan Cameron To: Lorenzo Bianconi Cc: Mario Tesi , lorenzo.bianconi83@gmail.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, mario.tesi@st.com Subject: Re: [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo Message-ID: <20190826095802.7aac9045@archlinux> In-Reply-To: <20190826082220.GA5328@localhost.localdomain> References: <1566480139-4015-1-git-send-email-martepisa@gmail.com> <20190826091537.66e07ec9@archlinux> <20190826082220.GA5328@localhost.localdomain> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Aug 2019 10:22:20 +0200 Lorenzo Bianconi wrote: > > On Thu, 22 Aug 2019 15:22:19 +0200 > > Mario Tesi wrote: > > > > > From: mario tesi > > > > > > According to the latest version of datasheet the mask > > > for number of unread sensor data in FIFO_STATUS registers > > > has been extended to 10 bits > > > > > > The devices involved are: > > > - LSM6DSO > > > - LSM6DSOX > > > - ASM330LHH > > > - LSM6DSR > > > - ISM330DHCX > > > > > > Signed-off-by: mario tesi > > > > Seems straight forward and should be side effect free I think. > > Hence I won't wait for Lorenzo to take a look (though there > > is still a small window for comments whilst the autobuilders > > poke at it!) > > > > Applied to the togreg branch of iio.git and pushed out as testing > > for the autobuilders to take a look. > > > > Thanks, > > Acked-by: Lorenzo Bianconi Nice. That was fast enough that I haven't applied any patches on top of Mario's yet so a quick git --amend job ;) Thanks, Jonathan > > > > > Jonathan > > > > > --- > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > index 85824d6..47b77d0 100644 > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > > > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > > > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > >