Re: [RESEND PATCH v3 10/20] mtd: spi-nor: Rework the SPI NOR lock/unlock logic

Tudor.Ambarus
2019-08-27T06:58:51Z

On 08/27/2019 09:36 AM, Vignesh Raghavendra wrote:
>> + nor->flags = SNOR_F_HAS_LOCK;
> This is okay for now. But Perhaps its safer to do:
>
> nor->flags |= SNOR_F_HAS_LOCK;
>
> so that we don't override flags if set earlier than
> spi_nor_manufacturer_init_params(). I see that patch 20/20 does indeed
> present one such case wrt atmel/Xilinix flashes IIUC

yep, you're right, I'll update as you suggested.

Thanks!