From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B95C3A5A3 for ; Tue, 27 Aug 2019 05:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 332F42173E for ; Tue, 27 Aug 2019 05:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KuMqge6v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729269AbfH0FKL (ORCPT ); Tue, 27 Aug 2019 01:10:11 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37082 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfH0FKK (ORCPT ); Tue, 27 Aug 2019 01:10:10 -0400 Received: by mail-pf1-f193.google.com with SMTP id y9so12933682pfl.4 for ; Mon, 26 Aug 2019 22:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kue46rIH4JbVHYlsaa+MeXhi8APX3bNmyCw0oXBiDLk=; b=KuMqge6vlDfh8jKRoUD1gXms5XSFdS1FlnpSUUgkV3Anmlc5b2oHqJbvmp9PRK9HwC cXoaHeEt91RFR/N/ICoDIUULdkm9h3zMfzEZUg03XCSuWbDcmXj6mlOFtvixsfmRpljM +f80ERIcyeyyyhaKaWGX+70wWZTaNrqFIFiQZwBBU31lphbOAMIXNQAfQkydWDf4u7VD ZUfkl/7pxtzhTER9JrlBceTvZGBiuHFxDYQPj3hNCwxhDaiTEVkDTAMBqqgZ67LE/pLm s28iAqXtdlfxdlO3SY/yKy70m/oc1Qbb8nWkxpueiPJk2i8QRIInyzbhB57hxPpRiAFI hgEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kue46rIH4JbVHYlsaa+MeXhi8APX3bNmyCw0oXBiDLk=; b=s8Z4i3QQ44+bgXKeSOwsxAr5DM+ylcoHYwLz5F1FtgvyaicvspTVOFOMQo/Rd85gF2 rG7kDZZARD0OfJcGtAFiw+iJoqQzIhTNZiRlFLeUuGLmln2UdnaoKEhoGl2jSWPSGRRo RmgRIh9gN/dpZc41qU8SJpVFsLmxkVhMwqWB8WmvxY+h9eWTjEZmSEIy0Tt07kgMA021 S1V4dc6W0pwgB6YlMcwijI8m6C89Z5ymWvV4sm8odQLGQXf3Uhb95FKQ1LwLytfGyktG RX6PC6guLJDA+djUdbnj3ElVW6eIVmZC/G6G/HSaw3MX6+SR3zo41NsKDBUyfy+cLLZw m1lA== X-Gm-Message-State: APjAAAWE3q1sNjBchFnHViIlegQEdmlcIC5jos4fZ1cceqAgZHxJTnEA 9or2xMjxIPz975XM6n4wxV25VSWMi+w= X-Google-Smtp-Source: APXvYqwcaGrGmBqQbq+ZXIx4wrncCySdMwJsO+BZOga+pwX1bi4P2t3U7PQxLtkRvcP8a/wee3hCMQ== X-Received: by 2002:a17:90a:250c:: with SMTP id j12mr23377818pje.96.1566882609922; Mon, 26 Aug 2019 22:10:09 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y8sm21644391pfr.140.2019.08.26.22.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Aug 2019 22:10:09 -0700 (PDT) Date: Mon, 26 Aug 2019 22:10:07 -0700 From: Bjorn Andersson To: Suman Anna Cc: linux-remoteproc@vger.kernel.org, Loic Pallardy , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK" Message-ID: <20190827051007.GK1263@builder> References: <20181024011909.21674-1-s-anna@ti.com> <40831f80-1e36-66ca-b8e5-684d46ba167e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40831f80-1e36-66ca-b8e5-684d46ba167e@ti.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 09 Aug 13:25 PDT 2019, Suman Anna wrote: > Hi Bjorn, > Hi Suman > On 10/23/18 8:19 PM, Suman Anna wrote: > > The virtio_rpmsg_bus driver uses the "%p" format-specifier for > > printing the vring buffer address. This prints only a hashed > > pointer even for previliged users. Use "%pK" instead so that > > the address can be printed during debug using kptr_restrict > > sysctl. > > Seems to have been lost among the patches, can you pick up this trivial > patch for 5.4? Should apply cleanly on the latest HEAD as well. > I share Andrew's question regarding what benefit you have from knowing this value. Should we not just remove the va from the print? Or do you actually have a use case for it? Regards, Bjorn > regards > Suman > > > > > Signed-off-by: Suman Anna > > --- > > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > > index f29dee731026..1345f373a1a0 100644 > > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > > @@ -950,7 +950,7 @@ static int rpmsg_probe(struct virtio_device *vdev) > > goto vqs_del; > > } > > > > - dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", > > + dev_dbg(&vdev->dev, "buffers: va %pK, dma %pad\n", > > bufs_va, &vrp->bufs_dma); > > > > /* half of the buffers is dedicated for RX */ > > >