From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8F5C3A5A6 for ; Tue, 27 Aug 2019 07:52:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19762206BF for ; Tue, 27 Aug 2019 07:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892357; bh=hBhas3GVFfsi+AHYvkMyLMZf4LS7PJ9FkZl7oEb0mmc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XqsDJbwgel+Rbg6Xdl4mNbSKJSHDm2+LGrudjalgZkB3XJ30sRe+iAQ5L/DX04Q6/ h7/FUke+NAuGPMm3c3hKS4nqGmDNn5g7C8UsZPyl8bLfa59TnYwBkH0OtyI22H6xPG B8+cMQjC3Vpy1evcTFLCryguq4xzvpwJlr3aTiW0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbfH0Hwg (ORCPT ); Tue, 27 Aug 2019 03:52:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729433AbfH0Hwc (ORCPT ); Tue, 27 Aug 2019 03:52:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93155206BA; Tue, 27 Aug 2019 07:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892351; bh=hBhas3GVFfsi+AHYvkMyLMZf4LS7PJ9FkZl7oEb0mmc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j8drBjgfBDsQOiw7S+z/kXYjAgIsi2unKPDD62X/fsE9pjW6O24CcW2jVkWNAz+WN ALJnPPqfjvAxR3/KQrK4gOSLN4wRv7GrK96ksosvjjkNVTyc4dQKbbwsrCQQxbrqF2 0q//IkXnSFxW82omNRXY1fYacgSYXlgJuc1nIC6k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiangfeng Xiao , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 26/62] net: hisilicon: fix hip04-xmit never return TX_BUSY Date: Tue, 27 Aug 2019 09:50:31 +0200 Message-Id: <20190827072701.978277279@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072659.803647352@linuxfoundation.org> References: <20190827072659.803647352@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit f2243b82785942be519016067ee6c55a063bbfe2 ] TX_DESC_NUM is 256, in tx_count, the maximum value of mod(TX_DESC_NUM - 1) is 254, the variable "count" in the hip04_mac_start_xmit function is never equal to (TX_DESC_NUM - 1), so hip04_mac_start_xmit never return NETDEV_TX_BUSY. tx_count is modified to mod(TX_DESC_NUM) so that the maximum value of tx_count can reach (TX_DESC_NUM - 1), then hip04_mac_start_xmit can reurn NETDEV_TX_BUSY. Signed-off-by: Jiangfeng Xiao Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 60ef6d40e4896..b04fb82d7fa3e 100644 --- a/drivers/net/ethernet/hisilicon/hip04_eth.c +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c @@ -185,7 +185,7 @@ struct hip04_priv { static inline unsigned int tx_count(unsigned int head, unsigned int tail) { - return (head - tail) % (TX_DESC_NUM - 1); + return (head - tail) % TX_DESC_NUM; } static void hip04_config_port(struct net_device *ndev, u32 speed, u32 duplex) -- 2.20.1