public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peikan Tsai <peikantsai@gmail.com>
Cc: christian.gromm@microchip.com, gustavo@embeddedor.com,
	suzuki.poulose@arm.com, colin.king@canonical.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most-core: Fix checkpatch warnings
Date: Tue, 27 Aug 2019 10:08:25 +0200	[thread overview]
Message-ID: <20190827080825.GA27271@kroah.com> (raw)
In-Reply-To: <20190825175849.GA74586@MarkdeMacBook-Pro.local>

On Mon, Aug 26, 2019 at 01:58:49AM +0800, Peikan Tsai wrote:
> Hi,
> 
> This patch solves the following checkpatch.pl's messages in drivers/staging/most/core.c.
> 
> WARNING: line over 80 characters
> +			return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name);
> 
> CHECK: Please use a blank line after function/struct/union/enum declarations
> +}
> +/**
> 
> Signed-off-by: Peikan Tsai <peikantsai@gmail.com>
> ---
>  drivers/staging/most/core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Normally we want only one "type" of cleanup per patch, but this is so
tiny I'll just take it as-is.

thanks,

greg k-h

      reply	other threads:[~2019-08-27  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 17:58 [PATCH] staging: most-core: Fix checkpatch warnings Peikan Tsai
2019-08-27  8:08 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827080825.GA27271@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=christian.gromm@microchip.com \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peikantsai@gmail.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox