public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: most-core: Fix checkpatch warnings
@ 2019-08-25 17:58 Peikan Tsai
  2019-08-27  8:08 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Peikan Tsai @ 2019-08-25 17:58 UTC (permalink / raw)
  To: gregkh, christian.gromm, gustavo, suzuki.poulose, colin.king
  Cc: devel, linux-kernel

Hi,

This patch solves the following checkpatch.pl's messages in drivers/staging/most/core.c.

WARNING: line over 80 characters
+			return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name);

CHECK: Please use a blank line after function/struct/union/enum declarations
+}
+/**

Signed-off-by: Peikan Tsai <peikantsai@gmail.com>
---
 drivers/staging/most/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index b9841adb7181..8e9a0b67c6ed 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -303,7 +303,8 @@ static ssize_t set_datatype_show(struct device *dev,
 
 	for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) {
 		if (c->cfg.data_type & ch_data_type[i].most_ch_data_type)
-			return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name);
+			return snprintf(buf, PAGE_SIZE, "%s",
+					ch_data_type[i].name);
 	}
 	return snprintf(buf, PAGE_SIZE, "unconfigured\n");
 }
@@ -721,6 +722,7 @@ int most_add_link(char *mdev, char *mdev_ch, char *comp_name, char *link_name,
 
 	return link_channel_to_component(c, comp, link_name, comp_param);
 }
+
 /**
  * remove_link_store - store function for remove_link attribute
  * @drv: device driver
-- 
2.13.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: most-core: Fix checkpatch warnings
  2019-08-25 17:58 [PATCH] staging: most-core: Fix checkpatch warnings Peikan Tsai
@ 2019-08-27  8:08 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-08-27  8:08 UTC (permalink / raw)
  To: Peikan Tsai
  Cc: christian.gromm, gustavo, suzuki.poulose, colin.king, devel,
	linux-kernel

On Mon, Aug 26, 2019 at 01:58:49AM +0800, Peikan Tsai wrote:
> Hi,
> 
> This patch solves the following checkpatch.pl's messages in drivers/staging/most/core.c.
> 
> WARNING: line over 80 characters
> +			return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name);
> 
> CHECK: Please use a blank line after function/struct/union/enum declarations
> +}
> +/**
> 
> Signed-off-by: Peikan Tsai <peikantsai@gmail.com>
> ---
>  drivers/staging/most/core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Normally we want only one "type" of cleanup per patch, but this is so
tiny I'll just take it as-is.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-27  8:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-25 17:58 [PATCH] staging: most-core: Fix checkpatch warnings Peikan Tsai
2019-08-27  8:08 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox