From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CACC3A5A3 for ; Tue, 27 Aug 2019 09:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EF62206BB for ; Tue, 27 Aug 2019 09:45:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAEHqRPg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbfH0JpE (ORCPT ); Tue, 27 Aug 2019 05:45:04 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37952 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728415AbfH0JpD (ORCPT ); Tue, 27 Aug 2019 05:45:03 -0400 Received: by mail-wr1-f65.google.com with SMTP id e16so1003074wro.5 for ; Tue, 27 Aug 2019 02:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6f+Icsxz68/2WUOQOXJPlnmhND3c9kjk7Qbbyj0A0kg=; b=DAEHqRPgmw98bL/haImN9fD6UfMYR1/S2NnQjdEW81PFCu9T2dceMxS2vBYT+J/OLc t2sru5JRJ0GKU0Zg8KmLGV4Rl/1mnBt8AMc4VqoVzpP4Bkq+eNnmp5LyyEsyu0HI+gAE I62570EvJBOCoNiTRpNvR+H7ZpvBO6rqAvAQ6Ao7dUAIRV6gvPmGQsXt5uQcy+M0MAO8 ZD6MvYoxL4JxOwg1W7lDM6k59M+/nFzr1vEiYlrKUCGp4+bNnquLtb5hJOzbAxX/qXDQ ZjaRJMCJJ9YOQJwIFZhpn7xBIG+rUxC3uNxq+C2cOxRgHVL9QDNuse/CwpjGabaHxouc s6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6f+Icsxz68/2WUOQOXJPlnmhND3c9kjk7Qbbyj0A0kg=; b=TDBjzrCta1WRuqlDTGtQb4C/wNr2p22rRnuY3A6+gOWAWsQbi7aMhcsna0ZMkQXvVh ShjGuiCox/8swCIP/NUHiCpYsA9BL0M0sUQRWNKLGKTaxhYEqVn0L7FuIIFETq32xP7R aGMvjti5hq+BBFMZjE+jBWHPbqeS9Pg3YQ3g5Oyvwf/MAS9m75L6jXZy8ooVkUZQLHKD hzOQGg54dHt08X2Frc1osZ4/xlXHxpSFgYQWMuWr3U+cSvz5AGIiWzkZsoN4q0oeTxYg pQZt5hU6CJ0gN0UkLPwfWxWHpfvH09HPJtuah6KeQ0p+3vcVE8n0phlOAPBniQG1I0MQ z6YA== X-Gm-Message-State: APjAAAXJTGeJ1+qpO9JspPbugngPVPk8wDnWme5wAePp7d45Zu5DozvV ryg+6lIN1KE8UC24XEnLvUHX3w== X-Google-Smtp-Source: APXvYqzj0vKC3iOhGGKsmddO0sx2ggiSMWTkca88AucPIDge5HC2ZDkK0IXCRr00WWZ8LAlMeqxRXw== X-Received: by 2002:adf:f5c5:: with SMTP id k5mr6828393wrp.42.1566899101785; Tue, 27 Aug 2019 02:45:01 -0700 (PDT) Received: from dell ([2.27.35.174]) by smtp.gmail.com with ESMTPSA id f24sm2510743wmc.25.2019.08.27.02.45.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Aug 2019 02:45:01 -0700 (PDT) Date: Tue, 27 Aug 2019 10:44:59 +0100 From: Lee Jones To: Daniel Thompson Cc: Matthias Kaehlcke , Thierry Reding , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Enric Balletbo i Serra , Douglas Anderson , Brian Norris , Pavel Machek , Jacek Anaszewski Subject: Re: [PATCH v3 2/4] backlight: Expose brightness curve type through sysfs Message-ID: <20190827094459.GB4804@dell> References: <20190709190007.91260-1-mka@chromium.org> <20190709190007.91260-3-mka@chromium.org> <20190807201528.GO250418@google.com> <510f6d8a-71a0-fa6e-33ea-c4a4bfa96607@linaro.org> <20190816175317.GU250418@google.com> <20190819100241.5pctjxmsq6crlale@holly.lan> <20190819185049.GZ250418@google.com> <20190820135617.64urowbu2kwdynib@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190820135617.64urowbu2kwdynib@holly.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > > IIUC the conclusion is that there is no need for a string attribute > > because we only need to distinguish between 'perceptual' and > > 'non-perceptual'. If that is correct, do you have any preference for > > the attribute name ('perceptual_scale', 'perceptual', ...)? > > More a summary than a conclusion! There is a reason I have left a bit or > space for others to comment on this over the last month (and a bit). > > To be clear my Reviewed-by: means that I believe that the kernel is better > with "non-linear/linear/unknown" than without it and that I am comfortable > the API isn't likely to be a millstone for us. > > Lee, Jingoo: Either of you care to offer $0.02 No, not really. Happy to leave it to your good judgement. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog