From: Christoph Hellwig <hch@lst.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uuid: Add helpers for finding UUID from an array
Date: Tue, 27 Aug 2019 13:54:18 +0200 [thread overview]
Message-ID: <20190827115418.GA5921@lst.de> (raw)
In-Reply-To: <20190827114918.25090-1-heikki.krogerus@linux.intel.com>
On Tue, Aug 27, 2019 at 02:49:18PM +0300, Heikki Krogerus wrote:
> Matching function that compares every UUID in an array to a
> given UUID with guid_equal().
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Hi,
>
> I don't have a user for these helpers, but since they are pretty
> trivial, I figured that might as well propose them in any case.
> Though, I think there was somebody proposing of doing the same thing
> that these helpers do at one point, but just the hard way in the
> drivers, right Andy?
XFS has something similar in xfs_uuid_mount, except that it also
tracks empty slots. That beeing said I'm pretty sure if you ask willy
he's suggest to just convert the table to an xarray instead :)
So I'm defintively curious what the users would be where we just check
a table, but don't also add something to the table.
next prev parent reply other threads:[~2019-08-27 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 11:49 [PATCH] uuid: Add helpers for finding UUID from an array Heikki Krogerus
2019-08-27 11:54 ` Christoph Hellwig [this message]
2019-08-27 12:26 ` Heikki Krogerus
2019-08-27 14:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827115418.GA5921@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox