From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EABDC3A5A4 for ; Tue, 27 Aug 2019 16:27:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3646A214DA for ; Tue, 27 Aug 2019 16:27:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="FbgrV/dT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730272AbfH0Q1W (ORCPT ); Tue, 27 Aug 2019 12:27:22 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36433 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726871AbfH0Q1W (ORCPT ); Tue, 27 Aug 2019 12:27:22 -0400 Received: by mail-qt1-f194.google.com with SMTP id z4so21924871qtc.3 for ; Tue, 27 Aug 2019 09:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lnAKsbXKD7RPlntdvWmMqnSDlV/9SfNV6+qNsMZx1qE=; b=FbgrV/dT3r1z1Rc57v9Qf+uj6Yns4EqBXIbLCnGw2bWmIq8rDwdBygEV2vnaYu0kPu gfjJuVB87hlqL7AXxQ9lTnxt+WHCCjh+Fcx2Ys6z6roLWd6N8yhxDPMKePNid5e8HLGG wBYtUi7fCu2yPOMpuQrWZKjxxhfIJIu/ht1MQGH1GkIwqMNAjAkW5xIESun2SaF3e3oo WZI9UbHjUVJT3l4FQWfBXyJGLIfyGy6K8l/rcedBmDY/PHebj023FKWikA6L0zspjfUp 92uKjwF/iSv2DfwwWX6kguce7dZXL6D3Nmx7vewGCXFNTlAR4t5yAf5tLPeexcBEb1TJ cdAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lnAKsbXKD7RPlntdvWmMqnSDlV/9SfNV6+qNsMZx1qE=; b=DSow2mH3eeFvRwi4Aiw/SHY4G+NP4oPF6B/rvQ5Isnur1jWqrw7haOMiI/553sfV7Y 2WN6Kn7UrGelbYN4xsnVdM9RGUwnFjkipjcgGXQaiCN9IhIsprmIOq7EwM6XfbxUABs7 zIkaE8ql1ZjtAUfciwF9N4nMDPP2Hx4d9oEciKgwHN7GQwc1h9/x21N/CBbJANlXvXVd nVxfCrCUZFz8OYUZbN4TcC7P7k15AcweVGrHf5L4Vo3pN09jFv0lL3adwlLT0t3/OWSn jP0UyIRohk41oopJdh24M2ZgjCsJgpJlLT2w1N6S3th+FHTlx24SLa2p5Yzee9/87aZb cJcA== X-Gm-Message-State: APjAAAXrUbzGKxKnReD6BQPJs2mP/G19ljpTDfl2N0LS8d7TDOrLSbjU nT4KV4nPUJvcM/GSMjBwV8U/jQ== X-Google-Smtp-Source: APXvYqyql8bxQV0/FB90h23PfUVjOUoxcX1fJUbzxMYDmwzWfOkMnMIARbD6dEDr2H7L/c0ocCf7Bg== X-Received: by 2002:a0c:9bc9:: with SMTP id g9mr20446108qvf.240.1566923241047; Tue, 27 Aug 2019 09:27:21 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-216-168.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.216.168]) by smtp.gmail.com with ESMTPSA id g8sm8649956qti.79.2019.08.27.09.27.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Aug 2019 09:27:20 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1i2eJU-00052e-2w; Tue, 27 Aug 2019 13:27:20 -0300 Date: Tue, 27 Aug 2019 13:27:20 -0300 From: Jason Gunthorpe To: Markus Elfring Cc: linux-rdma@vger.kernel.org, Doug Ledford , Johannes Berg , Leon Romanovsky , Parav Pandit , Steve Wise , Tatyana Nikolova , YueHaibing , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/iwpm: Delete =?utf-8?Q?un?= =?utf-8?Q?necessary_checks_before_the_macro_call_=E2=80=9Cdev=5Fkfree=5Fs?= =?utf-8?B?a2LigJ0=?= Message-ID: <20190827162720.GA19357@ziepe.ca> References: <16df4c50-1f61-d7c4-3fc8-3073666d281d@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16df4c50-1f61-d7c4-3fc8-3073666d281d@web.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 07:47:08PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 21 Aug 2019 19:30:09 +0200 > > The dev_kfree_skb() function performs also input parameter validation. > Thus the test around the shown calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/core/iwpm_msg.c | 9 +++------ > drivers/infiniband/core/iwpm_util.c | 9 +++------ > 2 files changed, 6 insertions(+), 12 deletions(-) Applied to for-next, thanks Jason