public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>
Subject: Re: [tip: perf/core] perf script: Fix memory leaks in list_scripts()
Date: Tue, 27 Aug 2019 14:45:45 -0700	[thread overview]
Message-ID: <20190827214545.GM5447@tassilo.jf.intel.com> (raw)
In-Reply-To: <b660a320-6b32-cc24-d829-1527dfc16e5d@embeddedor.com>

> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> This should be tagged for stable:
> 
> Cc: stable@vger.kernel.org

It's a theoretical problem (which are explicitely ruled out by stable rules)
because if you ever see user space malloc() returning NULL the system is likely
already randomly killing your processes in OOM, including eventually perf.

I can see the value of shutting up coverity though, but that's not something
that needs to be in stable.

-Andi

      reply	other threads:[~2019-08-27 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 16:27 [PATCH] perf script: Fix memory leaks in list_scripts() Gustavo A. R. Silva
2019-04-22 15:14 ` Gustavo A. R. Silva
2019-08-26  4:06   ` Gustavo A. R. Silva
2019-08-26 14:07     ` Arnaldo Carvalho de Melo
2019-08-26 15:59       ` Gustavo A. R. Silva
     [not found] ` <156689437793.24518.1210962260082729908.tip-bot2@tip-bot2>
2019-08-27 16:12   ` [tip: perf/core] " Gustavo A. R. Silva
2019-08-27 21:45     ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827214545.GM5447@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=gustavo@embeddedor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox