From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BDFC3A5A6 for ; Tue, 27 Aug 2019 21:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1D512184D for ; Tue, 27 Aug 2019 21:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566942375; bh=tki3pfge5Pp8AufwUnQHdHUzx+DqU3jb8sqUx2BxjZU=; h=In-Reply-To:References:Cc:Subject:To:From:Date:List-ID:From; b=l1VVtvLVXP+KvNC4J82b7wEr9tQWhArs0uca9dd/Uf4mlm8kiDEDtqhpjlK4CDMBH jOSIkNpGDv/Bee7DlTG3A460P+Gu39Z/JgpQJhGb4MVG+G52Do1loCaDQYNq+Ur3At YOHpB1lIoXCnmuL74h44IDxMElsKpt0jBt/wDRes= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfH0VqO (ORCPT ); Tue, 27 Aug 2019 17:46:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:48716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbfH0VqO (ORCPT ); Tue, 27 Aug 2019 17:46:14 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B896206E0; Tue, 27 Aug 2019 21:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566942373; bh=tki3pfge5Pp8AufwUnQHdHUzx+DqU3jb8sqUx2BxjZU=; h=In-Reply-To:References:Cc:Subject:To:From:Date:From; b=evLRI2DAOjd4yQdU9EyASSDdxXR6qBh3AxV0bRvwPYIa0EKsNZebexWIJvC+sUN10 /HeAgxhEf/DTnhB/OK/I+vvkukfE34VLXFKj6PxkHmNhE6t7kYCzEZE+M+jqOy4ow7 hoZ5aV0F9y9eDJdQ5AcvcaBmQHJCav/7VnyVQd+g= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190827174932.44177-1-brendanhiggins@google.com> References: <20190827174932.44177-1-brendanhiggins@google.com> Cc: kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, Brendan Higgins , Randy Dunlap , Stephen Rothwell Subject: Re: [PATCH v1] kunit: fix failure to build without printk To: Brendan Higgins , shuah@kernel.org From: Stephen Boyd User-Agent: alot/0.8.1 Date: Tue, 27 Aug 2019 14:46:12 -0700 Message-Id: <20190827214613.9B896206E0@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Brendan Higgins (2019-08-27 10:49:32) > Previously KUnit assumed that printk would always be present, which is > not a valid assumption to make. Fix that by ifdefing out functions which > directly depend on printk core functions similar to what dev_printk > does. >=20 > Reported-by: Randy Dunlap > Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fab= e016259df@kernel.org/T/#t > Cc: Stephen Rothwell > Signed-off-by: Brendan Higgins > --- Does kunit itself have any meaning if printk doesn't work? Why not just depend on CONFIG_PRINTK for now?