From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56BAC3A5A1 for ; Wed, 28 Aug 2019 18:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 717F2208C2 for ; Wed, 28 Aug 2019 18:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfH1SpQ (ORCPT ); Wed, 28 Aug 2019 14:45:16 -0400 Received: from muru.com ([72.249.23.125]:59038 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfH1SpP (ORCPT ); Wed, 28 Aug 2019 14:45:15 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 77A1A80C5; Wed, 28 Aug 2019 18:45:43 +0000 (UTC) Date: Wed, 28 Aug 2019 11:45:11 -0700 From: Tony Lindgren To: Aaro Koskinen Cc: Arnd Bergmann , Dominik Brodowski , linux-omap , Linux ARM , Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , Linux Kernel Mailing List Subject: Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf Message-ID: <20190828184511.GF52127@atomide.com> References: <20190813181158.GA26798@darkstar.musicnaut.iki.fi> <20190814074918.GA52127@atomide.com> <20190816083403.GB1952@darkstar.musicnaut.iki.fi> <20190827190453.GJ30291@darkstar.musicnaut.iki.fi> <20190828182318.GL30291@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828182318.GL30291@darkstar.musicnaut.iki.fi> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aaro Koskinen [190828 18:23]: > On Wed, Aug 28, 2019 at 03:02:36PM +0200, Arnd Bergmann wrote: > > I assume you checked that the uart output wasn't already broken > > by one of the earlier patches, right? > > Correct, it's only with the mapping change patch it hangs. > > > Also, looking at arch/arm/mach-omap1/include/mach/uncompress.h > > it seems that SX1 normally uses UART3, not UART1. > > Is that different in qemu? > > In QEMU all uarts can be used, trying with UART3 as early console > hangs as well. (It prints Uncompressing... done. but I guess that's > done with the physical address.) Hmm maybe we now need to get rid of the machine based detection code for DEBUGLL like we did for mach-omap2. Just get rid of arch_decomp_setup() in mach-omap1 uncompress.h file and make sure the assembly code only relies on the the Kconfig options only. That needs to be done at least for device tree based support since we use a generic machine ID. But maybe with multiarch support we need to rely on generic uncompress.h and assembly. Regards, Tony