[PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation

Austin Kim
2019-08-28T06:47:55Z

If the CONFIG_BUG is enabled, BUG() is executed and then system is crashed.
However, the bailout for mount is no longer proceeding.

For this reason, using WARN_ON rather than BUG() could prevent this situation.
---
fs/xfs/xfs_mount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 322da69..10fe000 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -213,8 +213,7 @@ xfs_initialize_perag(
goto out_hash_destroy;

spin_lock(&mp->m_perag_lock);
- if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
- BUG();
+ if (WARN_ON(radix_tree_insert(&mp->m_perag_tree, index, pag))){
spin_unlock(&mp->m_perag_lock);
radix_tree_preload_end();
error = -EEXIST;
--
2.6.2