From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1490CC3A59F for ; Thu, 29 Aug 2019 09:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7B48233A1 for ; Thu, 29 Aug 2019 09:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Qp4YqrbA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbfH2Jlj (ORCPT ); Thu, 29 Aug 2019 05:41:39 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44800 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfH2Jlj (ORCPT ); Thu, 29 Aug 2019 05:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q8X8dhA/6vAF+AyI3AiIHVKU1Euyk/tPwqRBlKklicU=; b=Qp4YqrbAp6gmjgNiliwXQIHwt nRs8d9FVhhUaeHT6jertsdc2IRcsAE94+0f/Yzww7ZhWVoQ6zaO0NlblC+NkjRsPyDMjf+anQeaZS 3gmw2BVrEjDCz6tXvW5NG1w9CmYtVRVfKA1Rtxpq1klbArrAWWkAJWZxSxg2w1xLi+3JaR+Dlqw+B 6hYWRyrV9FFsYUnLh7dQhzvqb2ZvYnJNXTvvPzIbSGrKUiMqpafkO0FM23JzX4B4QiFqjarTc533L H5Aoirn2g+OvtQj0FJNi9u2z5ax5EaP6JYGpYsjs2rA1xCYfcHInVyXzIAx94n6WqBv+OcWtHQhNh C+fpQ5ZUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3Gvw-0002B9-Ap; Thu, 29 Aug 2019 09:41:36 +0000 Date: Thu, 29 Aug 2019 02:41:36 -0700 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Christoph Hellwig , devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org, Sasha Levin , Valdis =?utf-8?Q?Kl=C4=93tnieks?= , linux-kernel@vger.kernel.org, OGAWA Hirofumi Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190829094136.GA28643@infradead.org> References: <20190828160817.6250-1-gregkh@linuxfoundation.org> <20190828170022.GA7873@kroah.com> <20190829062340.GB3047@infradead.org> <20190829063955.GA30193@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829063955.GA30193@kroah.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 08:39:55AM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote: > > Can we please just review the damn thing and get it into the proper > > tree? That whole concept of staging file systems just has been one > > fricking disaster, including Greg just moving not fully reviewed ones > > over like erofs just because he feels like it. I'm getting sick and > > tired of this scheme. > > For this filesystem, it's going to be a _lot_ of work before that can > happen, and I'd really like to have lots of people help out with it > instead of it living in random github trees for long periods of time. Did you actually look at the thing instead of blindly applying some pile of crap? It basically is a reimplementation of fs/fat/ not up to kernel standards with a few indirections thrown in to also support exfat. So no amount of work on this codebase is really going to bring us forward. Instead someone how can spend a couple days on this and actually has file systems to test it just needs to bring the low-level format bits over to our well tested fs/fat codebase instead of duplicating it.