From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>,
Stephen Bates <sbates@raithlin.com>,
Christoph Hellwig <hch@lst.de>,
Mike Rapoport <rppt@linux.ibm.com>,
Greentime Hu <greentime.hu@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Andrew Waterman <andrew@sifive.com>,
Olof Johansson <olof@lixom.net>,
Michael Clark <michaeljclark@mac.com>,
Rob Herring <robh@kernel.org>, Zong Li <zong@andestech.com>
Subject: Re: [PATCH v6] RISC-V: Implement sparsemem
Date: Thu, 29 Aug 2019 13:01:45 +0200 [thread overview]
Message-ID: <20190829110145.GA15360@lst.de> (raw)
In-Reply-To: <20190828214054.3562-1-logang@deltatee.com>
> diff --git a/arch/riscv/include/asm/fixmap.h b/arch/riscv/include/asm/fixmap.h
> index 9c66033c3a54..7b0259c044c9 100644
> --- a/arch/riscv/include/asm/fixmap.h
> +++ b/arch/riscv/include/asm/fixmap.h
> @@ -31,7 +31,7 @@ enum fixed_addresses {
> };
>
> #define FIXADDR_SIZE (__end_of_fixed_addresses * PAGE_SIZE)
> -#define FIXADDR_TOP (VMALLOC_START)
> +#define FIXADDR_TOP (VMEMMAP_START)
> #define FIXADDR_START (FIXADDR_TOP - FIXADDR_SIZE)
Note that this actually changes again in the fixes branch that
is targeted for 5.3. Not actually conflicting your functionality,
but the FIXADDR_TOP definition moves to pgtable.h.
Otherwise this still looks fine.
next prev parent reply other threads:[~2019-08-29 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 21:40 [PATCH v6] RISC-V: Implement sparsemem Logan Gunthorpe
2019-08-29 6:21 ` Mike Rapoport
2019-08-29 15:46 ` Logan Gunthorpe
2019-08-29 11:01 ` Christoph Hellwig [this message]
2019-08-29 23:38 ` Paul Walmsley
2019-08-29 23:41 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829110145.GA15360@lst.de \
--to=hch@lst.de \
--cc=andrew@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=michaeljclark@mac.com \
--cc=olof@lixom.net \
--cc=palmer@sifive.com \
--cc=robh@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=sbates@raithlin.com \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox