From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hung-Te Lin <hungte@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Guenter Roeck <linux@roeck-us.net>,
Allison Randal <allison@lohutok.net>,
Colin Ian King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Julius Werner <jwerner@chromium.org>,
Alexios Zavras <alexios.zavras@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] firmware: google: update vpd_decode from upstream
Date: Thu, 29 Aug 2019 13:24:07 +0200 [thread overview]
Message-ID: <20190829112407.GB23823@kroah.com> (raw)
In-Reply-To: <20190829101949.36275-1-hungte@chromium.org>
On Thu, Aug 29, 2019 at 06:19:45PM +0800, Hung-Te Lin wrote:
> The VPD implementation from Chromium Vital Product Data project used to
> parse data from untrusted input without checking if there is invalid
> data (for example the if the size becomes negative, or larger than whole
> input buffer), which may cause buffer overflow on corrupted data.
>
> To fix that, the upstream driver 'vpd_decode' has changed size
> parameters to unsigned integer (u32), and refactored the parsing of
> entry header so the size is always checked properly.
"the upstream driver"? That's the code you are touching here.
What do you mean by "upstream"? Your subject and this paragraph does
not make much sense.
Please describe exactly what you are doing here, we don't care what
anyone else did with this code in any random repo that is not Linus's
tree.
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-29 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 8:20 [PATCH] firmware: google: update vpd_decode from upstream Hung-Te Lin
2019-08-02 22:27 ` Stephen Boyd
2019-08-07 13:58 ` Guenter Roeck
2019-08-07 14:59 ` Stephen Boyd
2019-08-07 16:50 ` Guenter Roeck
2019-08-29 10:19 ` [PATCH v2] " Hung-Te Lin
2019-08-29 11:24 ` Greg Kroah-Hartman [this message]
2019-08-29 11:45 ` [PATCH v3] firmware: google: check if size is valid when decoding VPD data Hung-Te Lin
2019-08-29 14:51 ` Stephen Boyd
2019-08-30 2:23 ` [PATCH v4] " Hung-Te Lin
2019-08-30 5:03 ` Stephen Boyd
2019-08-30 16:54 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829112407.GB23823@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=colin.king@canonical.com \
--cc=hungte@chromium.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox