From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CE6C3A59F for ; Thu, 29 Aug 2019 11:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2262420674 for ; Thu, 29 Aug 2019 11:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfH2LP2 (ORCPT ); Thu, 29 Aug 2019 07:15:28 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59992 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfH2LP1 (ORCPT ); Thu, 29 Aug 2019 07:15:27 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 18C5527900A; Thu, 29 Aug 2019 12:15:24 +0100 (BST) Date: Thu, 29 Aug 2019 13:15:19 +0200 From: Boris Brezillon To: Vitor Soares Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-i3c@lists.infradead.org, bbrezillon@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, Joao.Pinto@synopsys.com Subject: Re: [PATCH 4/4] i3c: master: dw: reattach device on first available location of address table Message-ID: <20190829131519.3f420c64@collabora.com> In-Reply-To: References: Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Aug 2019 12:19:35 +0200 Vitor Soares wrote: > For today the reattach function only update the device address on the > controller. > > Update the location to the first available too, will optimize the > enumeration process avoiding additional checks to keep the available > positions on address table consecutive. Given the number of available slots I honestly don't think it makes a difference, but I also don't mind this change, so Reviewed-by: Boris Brezillon > > Signed-off-by: Vitor Soares > --- > drivers/i3c/master/dw-i3c-master.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c > index 1d83c97..62261ac 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -898,6 +898,22 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, > struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); > struct i3c_master_controller *m = i3c_dev_get_master(dev); > struct dw_i3c_master *master = to_dw_i3c_master(m); > + int pos; > + > + pos = dw_i3c_master_get_free_pos(master); > + > + if (data->index > pos && pos > 0) { > + writel(0, > + master->regs + > + DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); > + > + master->addrs[data->index] = 0; > + master->free_pos |= BIT(data->index); > + > + data->index = pos; > + master->addrs[pos] = dev->info.dyn_addr; > + master->free_pos &= ~BIT(pos); > + } > > writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr), > master->regs +