From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4239EC3A5A6 for ; Thu, 29 Aug 2019 13:50:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1867423405 for ; Thu, 29 Aug 2019 13:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567086626; bh=Uh2uOq4Ob8d47W0KPG477Y07xsJB4CFrYSm7rfe/lpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FqIvCFyMlNf2JGyD4EyDqbASy+i2SVGmKBSro4oDIde2zWR9mplxPv/RWM12r3nHI hApu/w4LCijWciw5oT2OIRKcSYs9WO4iXw2s3EOZ2O9krOR4eGPV1D6XzdxhvK+KjT OINx03MDndt6zsf5Q/TlYgMsVmvRrmPuslFVGREY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727648AbfH2NuZ (ORCPT ); Thu, 29 Aug 2019 09:50:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:51626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfH2NuZ (ORCPT ); Thu, 29 Aug 2019 09:50:25 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3C092189D; Thu, 29 Aug 2019 13:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567086623; bh=Uh2uOq4Ob8d47W0KPG477Y07xsJB4CFrYSm7rfe/lpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gnpWWrivvds3zCSxR7lT5mO2TVEjBrvDyEubxdQQAEQnUSQyMiQqQQyxGOE+jpNQR 4rHTs2rgPcr1vbx3N77UeqLyrbklguPRfTZv0h/WXZA9n0uzFe8HgP8IYePfD/tdfv PkNRjFnKaPmyOg1+uoAtsdYKTedgNq9AU2Fdl0b8= Date: Thu, 29 Aug 2019 09:50:22 -0400 From: Sasha Levin To: Heikki Krogerus Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kbuild test robot , Dan Carpenter Subject: Re: [PATCH 2/2] software node: Fix use of potentially uninitialized variable Message-ID: <20190829135022.GI5281@sasha-vm> References: <20190829132116.76120-1-heikki.krogerus@linux.intel.com> <20190829132116.76120-3-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190829132116.76120-3-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 04:21:16PM +0300, Heikki Krogerus wrote: >reported by smatch: >drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol 'swnode'. Could you describe the actual problem it fixes? Under what scenario would this issue occur and how would it manifest? We're not here to fix smatch warnings, we're here to fix bugs that smatch warns us about :) -- Thanks, Sasha