From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: sboyd@kernel.org, agross@kernel.org, jassisinghbrar@gmail.com,
niklas.cassel@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404
Date: Thu, 29 Aug 2019 06:59:44 -0700 [thread overview]
Message-ID: <20190829135944.GI26807@tuxbook-pro> (raw)
In-Reply-To: <20190829082759.6256-2-jorge.ramirez-ortiz@linaro.org>
On Thu 29 Aug 01:27 PDT 2019, Jorge Ramirez-Ortiz wrote:
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Nice, I like this version.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 705e17a5479c..d3676fd3cf94 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -47,7 +47,6 @@ static const struct mbox_chan_ops qcom_apcs_ipc_ops = {
>
> static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> {
> - struct device_node *np = pdev->dev.of_node;
> struct qcom_apcs_ipc *apcs;
> struct regmap *regmap;
> struct resource *res;
> @@ -55,6 +54,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> void __iomem *base;
> unsigned long i;
> int ret;
> + const struct of_device_id apcs_clk_match_table[] = {
> + { .compatible = "qcom,msm8916-apcs-kpss-global", },
> + { .compatible = "qcom,qcs404-apcs-apps-global", },
> + {}
> + };
>
> apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL);
> if (!apcs)
> @@ -89,7 +93,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
> + if (of_match_device(apcs_clk_match_table, &pdev->dev)) {
> apcs->clk = platform_device_register_data(&pdev->dev,
> "qcom-apcs-msm8916-clk",
> -1, NULL, 0);
> --
> 2.22.0
>
next prev parent reply other threads:[~2019-08-29 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 8:27 [PATCH v2 0/2] mbox changes for QCS404 DVFS Jorge Ramirez-Ortiz
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-29 13:59 ` Bjorn Andersson [this message]
2019-08-29 14:56 ` Stephen Boyd
2019-08-29 8:27 ` [PATCH v2 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-08-29 14:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829135944.GI26807@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox