Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

Ju Hyung Park
2019-09-18T22:17:23Z

Welp, looks like I didn't test debug configs properly.

Allow me 1-2 days to work on fixing it for v2.

Thanks in advance.

On Thu, Sep 19, 2019 at 6:31 AM kbuild test robot <lkp@intel.com> wrote:
>
> Hi Park,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.3 next-20190917]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Park-Ju-Hyung/staging-exfat-rebase-to-sdFAT-v2-2-0/20190919-040526
> config: x86_64-allyesconfig (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/staging/exfat/super.c: In function 'exfat_debug_kill_sb':
> >> drivers/staging/exfat/super.c:3079:4: error: implicit declaration of function 'exfat_cache_release'; did you mean 'exfat_dcache_release'? [-Werror=implicit-function-declaration]
> exfat_cache_release(sb);
> ^~~~~~~~~~~~~~~~~~~
> exfat_dcache_release
> cc1: some warnings being treated as errors
> --
> drivers/staging/exfat/misc.c: In function 'exfat_uevent_ro_remount':
> >> drivers/staging/exfat/misc.c:57:2: error: implicit declaration of function 'ST_LOG'; did you mean 'DT_REG'? [-Werror=implicit-function-declaration]
> ST_LOG("[EXFAT](%s[%d:%d]): Uevent triggered\n",
> ^~~~~~
> DT_REG
> cc1: some warnings being treated as errors
>
> vim +3079 drivers/staging/exfat/super.c
>
> 3063
> 3064 #ifdef CONFIG_EXFAT_DBG_IOCTL
> 3065 static void exfat_debug_kill_sb(struct super_block *sb)
> 3066 {
> 3067 struct exfat_sb_info *sbi = EXFAT_SB(sb);
> 3068 struct block_device *bdev = sb->s_bdev;
> 3069
> 3070 long flags;
> 3071
> 3072 if (sbi) {
> 3073 flags = sbi->debug_flags;
> 3074
> 3075 if (flags & EXFAT_DEBUGFLAGS_INVALID_UMOUNT) {
> 3076 /* invalidate_bdev drops all device cache include dirty.
> 3077 * we use this to simulate device removal
> 3078 */
> > 3079 exfat_cache_release(sb);
> 3080 invalidate_bdev(bdev);
> 3081 }
> 3082 }
> 3083
> 3084 kill_block_super(sb);
> 3085 }
> 3086 #endif /* CONFIG_EXFAT_DBG_IOCTL */
> 3087
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation