Re: [PATCH] staging: exfat: add exfat filesystem code to

Greg KH
2019-09-15T13:54:15Z

On Sat, Sep 14, 2019 at 10:39:51PM +0900, Park Ju Hyung wrote:
> Hi.
>
> I just noticed that this exfat-staging drivers are based on the old
> Samsung's 1.x exFAT drivers.
>
> I've been working to get the newer Samsung's driver(now named "sdFAT")
> to fit better for general Linux users, and I believe it can provide a
> better base for the community to work on(and hopefully complies better
> to the mainline coding standard).
>
> GitHub link
> https://github.com/arter97/exfat-linux
>
> I also included some rudimentary benchmark results.
>
> I encourage mainline developers to explore this driver base and see if
> it's worth to switch, since it's the early days of exfat-staging.

Note, this just showed up publically on August 12, where were you with
all of this new code before then? :)

> To others watching this thread:
> It's more than likely that you can start using exFAT reliably right
> away by following the link above. It's tested on all major LTS kernels
> ranging from 3.4 to 4.19 and the ones Canonical uses for Ubuntu: 3.4,
> 3.10, 3.18, 4.1, 4.4, 4.9, 4.14, 4.19 and 4.15, 5.0, 5.2, and 5.3-rc.

For the in-kernel code, we would have to rip out all of the work you did
for all older kernels, so that's a non-starter right there.

As for what codebase to work off of, I don't want to say it is too late,
but really, this shows up from nowhere and we had to pick something so
we found the best we could at that point in time.

Is there anything specific in the codebase you have now, that is lacking
in the in-kernel code? Old-kernel-support doesn't count here, as we
don't care about that as it is not applicable. But functionality does
matter, what has been added here that we can make use of?

And do you have any "real" development history to look at instead of the
"one giant commit" of the initial code drop? That is where we could
actually learn what has changed over time. Your repo as-is shows none
of the interesting bits :(

thanks,

greg kh