Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

Ju Hyung Park
2019-09-18T20:22:16Z

Hi Greg,

On Thu, Sep 19, 2019 at 5:12 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> That's a lot of rewriting :(
>
> How about at least keeping the file names the same to make it easier to
> see what happened here?
>
> Then send a follow-on patch that just does the rename?

That's still not quite useful tbh, lemme bring the diff stat I wrote
in previous email just in case you missed it:
<Full diff stat>
Kconfig | 79 +-
Makefile | 46 +-
api.c | 423 ----
api.h | 310 ---
blkdev.c | 409 +---
cache.c | 1142 ++++-----
config.h | 49 -
core.c | 5583 ++++++++++++++++++++++++--------------------
core.h | 196 --
core_exfat.c | 1553 ------------
exfat.h | 1309 +++++++----
exfat_fs.h | 417 ----
extent.c | 351 ---
fatent.c | 182 --
misc.c | 401 ----
nls.c | 490 ++--
super.c | 5103 +++++++++++++++++++++-------------------
upcase.c | 740 ++++++
upcase.h | 407 ----
version.h | 29 -
xattr.c | 136 --
21 files changed, 8186 insertions(+), 11169 deletions(-)

<diff-filter=M>
Kconfig | 79 +-
Makefile | 46 +-
blkdev.c | 409 +---
cache.c | 1142 +++++-----
core.c | 5583 ++++++++++++++++++++++++++----------------------
exfat.h | 1309 ++++++++----
nls.c | 490 ++---
super.c | 5103 ++++++++++++++++++++++---------------------
8 files changed, 7446 insertions(+), 6715 deletions(-)

These diff stats were taken by removing "exfat_" prefix from the
current staging drivers.

But if that's still what you want, I'll do it.
btw, removing "exfat_" prefix from the current one makes more sense imo.

If we add "exfat_" prefix to the new one, we get weird file names like
"exfat_core_exfat.c".

> And by taking something like this, are you agreeing that Samsung will
> help out with the development of this code to clean it up and get it
> into "real" mergable shape?

Well, I think you got me confused with Namjae.
(Yeah Korean names are confusing I know :) )

Namjae (or anyone else from Samsung) should answer that, not me.

I just prepared a patch as we were getting nowhere like you mentioned :)

> Also, I can't take this patch for this simple reason alone:
> Don't delete SPDX lines :)

Sorry.
I'll add that back for v2.

On Thu, Sep 19, 2019 at 5:13 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote:
> > --- a/drivers/staging/exfat/exfat.h
> > +++ b/drivers/staging/exfat/exfat.h
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> You just changed the license of this file. Are you SURE about that?

The sdFAT code release explicitly states "either version 2 of the
License, or (at your option) any later version", so I thought that
makes sense:
https://github.com/arter97/exfat-linux/commit/d5393c4cbe0e5b50231aacd33d9b5b0ddf46a005

Please correct me if I'm wrong.

Thanks.