From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace
Date: Fri, 30 Aug 2019 07:55:14 +0200 [thread overview]
Message-ID: <20190830055514.GC8492@lst.de> (raw)
In-Reply-To: <ac168168-fed2-2b57-493e-e88261ead73b@grimberg.me>
On Thu, Aug 29, 2019 at 11:21:02AM -0700, Sagi Grimberg wrote:
>> Yes we do, userspace should use it to order events. Does udev not
>> handle that properly today?
>
> The problem is not ordering of events, its really about the fact that
> the chardev can be removed and reallocated for a different controller
> (could be a completely different discovery controller) by the time
> that userspace handles the event.
The same is generally true for lot of kernel devices. We could reduce
the chance by using the idr cyclic allocator.
next prev parent reply other threads:[~2019-08-30 5:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190712180211.26333-1-sagi@grimberg.me>
[not found] ` <20190712180211.26333-4-sagi@grimberg.me>
[not found] ` <20190822002328.GP9511@lst.de>
[not found] ` <205d06ab-fedc-739d-323f-b358aff2cbfe@grimberg.me>
[not found] ` <e4603511-6dae-e26d-12a9-e9fa727a8d03@grimberg.me>
2019-08-26 6:56 ` [PATCH v2 3/3] nvme: fire discovery log page change events to userspace Christoph Hellwig
2019-08-26 7:59 ` Greg Kroah-Hartman
2019-08-29 18:21 ` Sagi Grimberg
2019-08-30 5:55 ` Christoph Hellwig [this message]
2019-08-30 18:08 ` Sagi Grimberg
2019-08-30 18:36 ` James Smart
2019-08-30 21:07 ` Sagi Grimberg
2019-08-30 22:24 ` James Smart
2019-09-09 15:10 ` Hannes Reinecke
2019-08-30 6:20 ` Greg Kroah-Hartman
2019-08-30 18:14 ` Sagi Grimberg
2019-09-02 19:33 ` Greg Kroah-Hartman
2019-09-04 1:35 ` Sagi Grimberg
2019-09-04 5:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830055514.GC8492@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox