Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

Wolfram Sang
2019-08-30T13:00:39Z

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

> > > I'm confused because I already applied:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=7150710f3084de8d35ce3221eeae2caee8813f92
> >
> > The above was a mass conversion to i2c_new_dummy_device() to make sure
> > all in-kernel users use the API returning an ERRPTR. Mass conversion to
> > the devm_ variant of the same function was too troublesome.
> >
> > With another series, I wanted to remove superfluous error checking of
> > i2c_unregister_device() because it is NULL-ptr safe, like here:
> >
> > > > - if (info->rtc)
> > > > - i2c_unregister_device(info->rtc);
> >
> > But for these two RTC drivers, I figured moving to devm_* is way easier
> > than fixing up the mass conversion result from coccinelle.
> >
>
> Ok so should I drop the previous patches and apply those instead?

Nope, they should be incremental, aren't they?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]