Re: [PATCH v6 01/24] erofs: add on-disk layout

Christoph Hellwig
2019-08-29T10:36:18Z

On Thu, Aug 29, 2019 at 06:32:53PM +0800, Gao Xiang wrote:
> I can fix it up as you like but I still cannot get
> what is critical issues here.

The problem is that the whole codebase is way substandard quality,
looking a lot like Linux code from 20 years ago. Yes, we already have
plenty of code of that standard in the tree, but we should not add more.