Re: [PATCH v6 05/24] erofs: add inode operations

Gao Xiang
2019-08-29T12:00:23Z

On Thu, Aug 29, 2019 at 03:24:26AM -0700, Christoph Hellwig wrote:

[]

>
> > +
> > + /* fill last page if inline data is available */
> > + err = fill_inline_data(inode, data, ofs);
>
> Well, I think you should move the is_inode_flat_inline and
> (S_ISLNK(inode->i_mode) && inode->i_size < PAGE_SIZE) checks from that
> helper here, as otherwise you make everyone wonder why you'd always
> fill out the inline data.

Currently, fill_inline_data() only fills for fast symlink,
later we can fill any tail-end block (such as dir block)
for our requirements.

And I think that is minor.

>
> > +static inline struct inode *erofs_iget_locked(struct super_block *sb,
> > + erofs_nid_t nid)
> > +{
> > + const unsigned long hashval = erofs_inode_hash(nid);
> > +
> > +#if BITS_PER_LONG >= 64
> > + /* it is safe to use iget_locked for >= 64-bit platform */
> > + return iget_locked(sb, hashval);
> > +#else
> > + return iget5_locked(sb, hashval, erofs_ilookup_test_actor,
> > + erofs_iget_set_actor, &nid);
> > +#endif
>
> Just use the slightly more complicated 32-bit version everywhere so that
> you have a single actually tested code path. And then remove this
> helper.

The consideration is simply because iget_locked performs better
than iget5_locked.

Thanks,
Gao Xiang