Re: [PATCH v6 04/24] erofs: add raw address_space operations

Christoph Hellwig
2019-08-30T16:40:26Z

On Thu, Aug 29, 2019 at 07:46:11PM +0800, Gao Xiang wrote:
> Hi Christoph,
>
> On Thu, Aug 29, 2019 at 03:17:21AM -0700, Christoph Hellwig wrote:
> > The actual address_space operations seem to largely duplicate
> > the iomap versions. Please use those instead. Also I don't think
> > any new file system should write up ->bmap these days.
>
> iomap doesn't support tail-end packing inline data till now,
> I think Chao and I told you and Andreas before [1].
>
> Since EROFS keeps a self-contained driver for now, we will use
> iomap if it supports tail-end packing inline data later.

Well, so work with the maintainers to enhance the core kernel. That
is how Linux development works. We've added various iomap enhancements
for gfs in the last merge windows, and we've added more for the brand
new zonefs file system we plan to merge for 5.4.