Re: [PATCH v6 06/24] erofs: support special inode

Gao Xiang
2019-09-01T09:39:34Z

Hi Christoph,

On Thu, Aug 29, 2019 at 03:25:03AM -0700, Christoph Hellwig wrote:
> On Fri, Aug 02, 2019 at 08:53:29PM +0800, Gao Xiang wrote:
> > This patch adds to support special inode, such as
> > block dev, char, socket, pipe inode.
> >
> > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> > ---
> > fs/erofs/inode.c | 27 +++++++++++++++++++++++++--
> > 1 file changed, 25 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c
> > index b6ea997bc4ae..637bf6e4de44 100644
> > --- a/fs/erofs/inode.c
> > +++ b/fs/erofs/inode.c
> > @@ -34,7 +34,16 @@ static int read_inode(struct inode *inode, void *data)
> > vi->xattr_isize = ondisk_xattr_ibody_size(v2->i_xattr_icount);
> >
> > inode->i_mode = le16_to_cpu(v2->i_mode);
> > - vi->raw_blkaddr = le32_to_cpu(v2->i_u.raw_blkaddr);
> > + if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> > + S_ISLNK(inode->i_mode))
> > + vi->raw_blkaddr = le32_to_cpu(v2->i_u.raw_blkaddr);
> > + else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode))
> > + inode->i_rdev =
> > + new_decode_dev(le32_to_cpu(v2->i_u.rdev));
> > + else if (S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode))
> > + inode->i_rdev = 0;
> > + else
> > + return -EIO;
>
> Please use a switch statement when dealing with the file modes to
> make everything easier to read.

Fixed in
https://lore.kernel.org/linux-fsdevel/20190901055130.30572-18-hsiangkao@aol.com/

Thanks,
Gao Xiang