Re: [PATCH v6 05/24] erofs: add inode operations

Christoph Hellwig
2019-09-02T12:53:26Z

On Sun, Sep 01, 2019 at 05:34:00PM +0800, Gao Xiang wrote:
> > > + return iget5_locked(sb, hashval, erofs_ilookup_test_actor,
> > > + erofs_iget_set_actor, &nid);
> > > +#endif
> >
> > Just use the slightly more complicated 32-bit version everywhere so that
> > you have a single actually tested code path. And then remove this
> > helper.
>
> As I said before, 64-bit platforms is common currently,
> I think iget_locked is enough.
> https://lore.kernel.org/r/20190830184606.GA175612@architecture4/

The problem with that is that you now have two entirely different
code paths. And the 32-bit one will probably get very little testing
and eventually bitrot. We defintively had problems of that sort in
XFS in the past, so my suggestion is to not go down the root of
separate code for 32-bit vs 64-bit unless it makes a real difference
for a real-life workload.