Re: [PATCH v6 01/24] erofs: add on-disk layout

Pavel Machek
2019-09-02T08:43:07Z

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

Hi!

> > > Rather than they didn't run "gdb" or "pahole" and change it by mistake.
> >
> > I think Christoph is not right here.
> >
> > Using external tools for validation is extra work
> > when necessary for understanding the code.
>
> The advantage of using the external tools that the information about
> offsets is provably correct ...

No. gdb tells you what the actual offsets _are_.

> > The expected offset is somewhat valuable, but
> > perhaps the form is a bit off given the visual
> > run-in to the field types.
> >
> > The extra work with this form is manipulating all
> > the offsets whenever a structure change occurs.
>
> ... while this is error prone.

While the comment tells you what they _should be_.

Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]