Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

Eugen.Hristev
2019-09-02T08:54:10Z

On 31.08.2019 15:17, Wolfram Sang wrote:
>
>>> + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
>>> + "i2c-dig-filter");
>>> +
>>
>> What do you think of the idea to introduce 'flags' to struct i2c_timings
>> and parse the bindings in the core, too? Then you'd have sth like:
>>
>> if (t->flags & I2C_TIMINGS_ANALOG_FILTER)
>>
>> Would that be useful for you?
>
> Forgot to say, we can also implement this incrementally to make sure
> your patches land in 5.4 in case you are currently busy with sth else.
>

Hi Wolfram,

Your idea looks good but I would prefer to have it as a separate
enhancement patch, after this series gets in.
As things are now, this series/patches do just the filtering part. We
can then move all the optional 'flags' as another change.
So yes, we can do this incrementally.

Thanks !
Eugen

>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>