From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426A2C3A5A4 for ; Sun, 1 Sep 2019 17:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E84922CE9 for ; Sun, 1 Sep 2019 17:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729058AbfIARYS (ORCPT ); Sun, 1 Sep 2019 13:24:18 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:39184 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728570AbfIARYS (ORCPT ); Sun, 1 Sep 2019 13:24:18 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 86F49815E8; Sun, 1 Sep 2019 19:24:02 +0200 (CEST) Date: Sun, 1 Sep 2019 19:24:15 +0200 From: Pavel Machek To: Sakari Ailus Cc: Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list , devicetree@vger.kernel.org Subject: Re: [RFC 1/5] media: dt-bindings: Document 'location' property Message-ID: <20190901172414.GB1047@bug> References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-2-jacopo@jmondi.org> <20190815065635.GJ6133@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815065635.GJ6133@paasikivi.fi.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -89,6 +89,10 @@ Optional properties > > but a number of degrees counter clockwise. Typical values are 0 and 180 > > (upside down). > > > > +- location: The camera device mounting position, relative to the device > > + usage orientation. Possible values are: > > + 0 - Front camera. The image sensor is mounted on the front side of the device. > > + 1 - Back camera. The image sensor is mounted on the back side of the device. > > Would it make sense to make this a little more generic? Such as s/image > sensor/ device/, for instance? > > Is this also relevant for flash or lens devices? > > Flash (torch) devices could be present, at least principle, without a > camera. There once was even such a Nokia phone, 1100 unless I'm mistaken. > :-) Well, I'd call them LEDs, not camera flashes ... if there's no camera. And IIRC these devices had LEDs on top of the phone... so neither front nor back side. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html