Re: [greybus-dev] [PATCH 5/9] staging: greybus: log: Fix up some alignment checkpatch issues

Viresh Kumar
2019-08-26T06:12:39Z

On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> Some function prototypes do not match the expected alignment formatting
> so fix that up so that checkpatch is happy.
>
> Cc: David Lin <dtwlin@gmail.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: greybus-dev@lists.linaro.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/greybus/log.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/log.c b/drivers/staging/greybus/log.c
> index 15a88574dbb0..4f1f161ff11c 100644
> --- a/drivers/staging/greybus/log.c
> +++ b/drivers/staging/greybus/log.c
> @@ -31,14 +31,14 @@ static int gb_log_request_handler(struct gb_operation *op)
> /* Verify size of payload */
> if (op->request->payload_size < sizeof(*receive)) {
> dev_err(dev, "log request too small (%zu < %zu)\n",
> - op->request->payload_size, sizeof(*receive));
> + op->request->payload_size, sizeof(*receive));
> return -EINVAL;
> }
> receive = op->request->payload;
> len = le16_to_cpu(receive->len);
> if (len != (op->request->payload_size - sizeof(*receive))) {
> dev_err(dev, "log request wrong size %d vs %zu\n", len,
> - (op->request->payload_size - sizeof(*receive)));
> + (op->request->payload_size - sizeof(*receive)));
> return -EINVAL;
> }
> if (len == 0) {
> @@ -83,7 +83,7 @@ static int gb_log_probe(struct gb_bundle *bundle,
> return -ENOMEM;
>
> connection = gb_connection_create(bundle, le16_to_cpu(cport_desc->id),
> - gb_log_request_handler);
> + gb_log_request_handler);
> if (IS_ERR(connection)) {
> retval = PTR_ERR(connection);
> goto error_free;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh