From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE250C3A59B for ; Mon, 2 Sep 2019 08:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C558B22DD6 for ; Mon, 2 Sep 2019 08:02:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l4oUO988" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730164AbfIBICj (ORCPT ); Mon, 2 Sep 2019 04:02:39 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:58302 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730036AbfIBICT (ORCPT ); Mon, 2 Sep 2019 04:02:19 -0400 Received: from pendragon.ideasonboard.com (231.125-247-81.adsl-dyn.isp.belgacom.be [81.247.125.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D2A0303; Mon, 2 Sep 2019 10:02:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1567411337; bh=9LpLDBZKeRKxbRTdwGzHizcveEKiifXyzbvf6jL+liQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4oUO988Hlc4uTdtzaHPaZBcV30LXMyIR1ns7Ywb9XZhhkX6dXKaawv+8gDacGTqR pX6ZkK0asuMtPvXmXgwPYY3LdyNOirfYSlhJpz6yUaj65XTRlet3PMwl3d40Pom9Yt rq3DS4oYOEZlq5VQHWw7i6i2ZUbG4fZRQKf4k5Ug= Date: Mon, 2 Sep 2019 11:02:11 +0300 From: Laurent Pinchart To: Pavel Machek Cc: Sakari Ailus , Jacopo Mondi , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list , devicetree@vger.kernel.org Subject: Re: [RFC 1/5] media: dt-bindings: Document 'location' property Message-ID: <20190902080211.GD4777@pendragon.ideasonboard.com> References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-2-jacopo@jmondi.org> <20190815065635.GJ6133@paasikivi.fi.intel.com> <20190901172414.GB1047@bug> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190901172414.GB1047@bug> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On Sun, Sep 01, 2019 at 07:24:15PM +0200, Pavel Machek wrote: > > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > > @@ -89,6 +89,10 @@ Optional properties > > > but a number of degrees counter clockwise. Typical values are 0 and 180 > > > (upside down). > > > > > > +- location: The camera device mounting position, relative to the device > > > + usage orientation. Possible values are: > > > + 0 - Front camera. The image sensor is mounted on the front side of the device. > > > + 1 - Back camera. The image sensor is mounted on the back side of the device. > > > > Would it make sense to make this a little more generic? Such as s/image > > sensor/ device/, for instance? > > > > Is this also relevant for flash or lens devices? > > > > Flash (torch) devices could be present, at least principle, without a > > camera. There once was even such a Nokia phone, 1100 unless I'm mistaken. > > :-) > > Well, I'd call them LEDs, not camera flashes ... if there's no camera. And IIRC > these devices had LEDs on top of the phone... so neither front nor back side. I would go for the name "torch" in that case. It really depends on the device, but in any case, the torch LEDs would have a location (and we would possibly need to expand this property to include the top, bottom, left and right sides). -- Regards, Laurent Pinchart