From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20451C3A5A5 for ; Mon, 2 Sep 2019 21:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E14E022DCC for ; Mon, 2 Sep 2019 21:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460311; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j8SjGnOEzUEltm9HmKPMrQV7YFB+0QNTBDsNYaL9yWljGdl0vmw+nJSr+H6TKpBwb Tj8/TgGforoY9iVPeUaDZycXf5fIcFITawjtmGZEsq+R9oor9deE2IYvxbF3hX4Iaf 9DzXnlj3APL2JKj0bBjcarDKVxwu5qyR4UCjDSIU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727758AbfIBVia (ORCPT ); Mon, 2 Sep 2019 17:38:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:49356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727318AbfIBVi3 (ORCPT ); Mon, 2 Sep 2019 17:38:29 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABC520828; Mon, 2 Sep 2019 21:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567460308; bh=kaaq401nmBdTSHu/XiUBD70JNneEb8DIrs7hzf+jJHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zWpp0ekwFLO9mEtnMHUAEc17a8bDcIff1Kozu6gDr4uXN3F9z04i1GNSj/QOZ5rKe FuHpA83H1qV8KrwcFIOyzgWaTfrOqG2VvFNMund6t/JQJRgqCUafDAKfxyeOndoZtF quD/TKjyWIqOB1/QEOmWDfYieCsTGdVxuxScOlfE= Date: Mon, 2 Sep 2019 16:38:26 -0500 From: Bjorn Helgaas To: Christoph Hellwig Cc: Krzysztof Wilczynski , Will Deacon , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, Robin Murphy , David Woodhouse , linux-arm-kernel@lists.infradead.org, Kelsey Skunberg Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h Message-ID: <20190902213826.GI7013@google.com> References: <20190830150756.21305-1-kw@linux.com> <20190830161840.GA9733@infradead.org> <20190902211100.GH7013@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902211100.GH7013@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Kelsey] On Mon, Sep 02, 2019 at 04:11:00PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > > Move ATS function prototypes from include/linux/pci-ats.h to > > > include/linux/pci.h so users only need to include : > > > > Why is that so important? Very few PCI(e) device drivers use ATS, > > so keeping it out of everyones include hell doesn't seem all bad. > > This was my idea, and it wasn't a good one, sorry. > > The ATS, PRI, and PASID interfaces are all sort of related and are > used only by the IOMMU drivers, so it probably makes sense to put them > all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID > stuff is in linux/pci-ats.h. Maybe the right thing would be to move > the ATS stuff to pci-ats.h. > > I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: > Move ATS declarations to linux/pci.h so they're all together") with > the excuse of putting the external ATS interfaces next to > pci_ats_init(). But that really looks like it was a mistake because > pci_ats_init() is a PCI-internal thing and its declaration should > probably be in drivers/pci/pci.h instead. Never mind the pci_ats_init() part; Kelsey has already moved that: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=b92b512a435d