From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC18C3A5A2 for ; Tue, 3 Sep 2019 09:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADF5423402 for ; Tue, 3 Sep 2019 09:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567503218; bh=NRTEkLhjDekB8QQSnVDsDRRMHjFNQ3z8KPm/6p9Qc6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BrN60rNGPyd8QJ/FN2+U8ovbzbO25NOl3Gd/UQ3pQSe26SjCuqLjIxuAT5lfj1yHp nxQdvjPKaXndbl/htSl1XW1JbnCtuMSaWUIDATr4p8hnTNnf3jaXtYKkBZ9zbRNi48 w8mbk6hwlc05HZFyKpsbQ4XYH+gAu6H6mK4LAQNY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728859AbfICJdh (ORCPT ); Tue, 3 Sep 2019 05:33:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:55364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728836AbfICJdf (ORCPT ); Tue, 3 Sep 2019 05:33:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66E5522DBF; Tue, 3 Sep 2019 09:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567503214; bh=NRTEkLhjDekB8QQSnVDsDRRMHjFNQ3z8KPm/6p9Qc6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hRB4E5qWMntCDKmwywBVHqSDJPNT/kRUZUhDPZRlYoI3yNmqoP8KKIeI1OadLa+ab LEUEJLoffIt6gZBqGZzP4e92ppjUMP+AnaOpWbxyPHR9d/IrGS8U9cv9+cczfWgpOj jdm8conexHveJcBEjBQ4biHJenordlxJ0h/lYkm8= Date: Tue, 3 Sep 2019 11:33:32 +0200 From: Greg KH To: Prakhar Sinha Cc: tobias.niessen@stud.uni-hannover.de, kim.jamie.bradley@gmail.com, pakki001@umn.edu, sabrina-gaube@web.de, nishkadg.linux@gmail.com, qader.aymen@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: Modified nested if blocks. Message-ID: <20190903093332.GC12325@kroah.com> References: <20190903090240.GA6104@MeraComputer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903090240.GA6104@MeraComputer> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 02:32:40PM +0530, Prakhar Sinha wrote: > This patch solves the following checkpatch.pl's messages in > drivers/staging/rts5208/sd.c > > WARNING: line over 80 characters > 4517: FILE: drivers/staging/rts5208/sd.c:4517: > + sd_card->sd_lock_status &= > ~(SD_UNLOCK_POW_ON | SD_SDR_RST); > > WARNING: line over 80 characters > 4518: FILE: drivers/staging/rts5208/sd.c:4518: > + goto > sd_execute_write_cmd_failed; Please keep the full line without wrapping them in these messages. And your subject is a big odd, look at the documentation for how to create a good subject line. thanks, greg k-h