From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A12EC3A5A7 for ; Tue, 3 Sep 2019 15:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C8E3215EA for ; Tue, 3 Sep 2019 15:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbfICPI6 (ORCPT ); Tue, 3 Sep 2019 11:08:58 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36254 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729169AbfICPI4 (ORCPT ); Tue, 3 Sep 2019 11:08:56 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8305628B338; Tue, 3 Sep 2019 16:08:53 +0100 (BST) Date: Tue, 3 Sep 2019 17:08:50 +0200 From: Boris Brezillon To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Arnd Bergmann , Linux Kernel Mailing List , Mark Brown , linux-spi , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Miquel Raynal , Vignesh Raghavendra , MTD Maling List Subject: Re: [PATCH] eeprom: at25: Convert the driver to the spi-mem interface Message-ID: <20190903170850.6aee808b@collabora.com> In-Reply-To: References: <20190330141637.22632-1-boris.brezillon@collabora.com> <20190425194451.GA14552@kroah.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Tue, 3 Sep 2019 17:06:52 +0200 Geert Uytterhoeven wrote: > On Thu, Apr 25, 2019 at 9:44 PM Greg Kroah-Hartman > wrote: > > On Sat, Mar 30, 2019 at 03:16:37PM +0100, Boris Brezillon wrote: > > > The AT25 protocol fits pretty well in the spi-mem model. Convert the > > > at25 spi driver to a spi-mem driver and use the dirmap API instead of > > > forging SPI messages manually. > > > This makes the driver compatible with spi-mem-only controllers > > > (controllers implementing only the spi_mem ops). > > > > > > Cc: Geert Uytterhoeven > > > Signed-off-by: Boris Brezillon > > > --- > > > drivers/misc/eeprom/at25.c | 282 +++++++++++++++++++++++-------------- > > > 1 file changed, 176 insertions(+), 106 deletions(-) > > > > Will there be a new version of this to fix up the problems that 0-day > > found in it? > > gmail-whitespace-damaged fix: > > diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig > index f2abe27010eff133..98145d7d43d0c728 100644 > --- a/drivers/misc/eeprom/Kconfig > +++ b/drivers/misc/eeprom/Kconfig > @@ -36,6 +36,7 @@ config EEPROM_AT25 > depends on SPI && SYSFS > select NVMEM > select NVMEM_SYSFS > + select SPI_MEM > help > Enable this driver to get read/write support to most SPI EEPROMs, > after you configure the board init code to know about each eeprom > > Boris: what's the plan? Sorry, I don't have time to respin this patch. Feel free to send a new version if you need it. Regards, Boris