From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6941FC3A5A2 for ; Tue, 3 Sep 2019 17:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43AFF21881 for ; Tue, 3 Sep 2019 17:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730117AbfICRRB (ORCPT ); Tue, 3 Sep 2019 13:17:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54293 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729499AbfICRRB (ORCPT ); Tue, 3 Sep 2019 13:17:01 -0400 Received: from 1.general.cascardo.us.vpn ([10.172.70.58] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1i5CQM-0006gX-Vl; Tue, 03 Sep 2019 17:16:59 +0000 From: Thadeu Lima de Souza Cascardo To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Thadeu Lima de Souza Cascardo Subject: [PATCH 1/2] sched: sched_getattr should return E2BIG, not EFBIG Date: Tue, 3 Sep 2019 14:16:44 -0300 Message-Id: <20190903171645.28090-1-cascardo@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As documented and the behavior before commit 22400674945c (sched: Simplify return logic in sched_read_attr()), sched_getattr should return E2BIG instead of EFBIG when there is not enough space to copy sched_attr. Signed-off-by: Thadeu Lima de Souza Cascardo Fixes: 22400674945c (sched: Simplify return logic in sched_read_attr()) --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 2477893dd069..0fd67281e656 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5129,7 +5129,7 @@ static int sched_read_attr(struct sched_attr __user *uattr, for (; addr < end; addr++) { if (*addr) - return -EFBIG; + return -E2BIG; } attr->size = usize; -- 2.20.1