Re: [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

John Kacur
2019-09-16T21:57:42Z

On Tue, 3 Sep 2019, Sultan Alsawaf wrote:

> From: Sultan Alsawaf <sultan@kerneltoast.com>
>
> Architecture-specific uaccess.h headers can have dependencies on
> linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly.
> Since linux/uaccess.h includes asm/uaccess.h, just do that instead.
>
> This fixes compile errors with certain kernels and architectures.
>
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> ---
> src/backfire/backfire.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
> index aaf9c4a..a8ac9f5 100644
> --- a/src/backfire/backfire.c
> +++ b/src/backfire/backfire.c
> @@ -30,8 +30,8 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/spinlock.h>
> +#include <linux/uaccess.h>
>
> -#include <asm/uaccess.h>
> #include <asm/system.h>
>
> #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
> --
> 2.23.0
>
>

Signed-off-by: John Kacur <jkacur@redhat.com>
But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Thanks