From: "Michal Suchánek" <msuchanek@suse.de>
To: Vinod Koul <vkoul@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
alsa-devel@alsa-project.org,
Sanyog Kale <sanyog.r.kale@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
Date: Wed, 4 Sep 2019 12:48:03 +0200 [thread overview]
Message-ID: <20190904124803.1700a65a@naga> (raw)
In-Reply-To: <20190904093052.GQ2672@vkoul-mobl>
On Wed, 4 Sep 2019 15:00:52 +0530
Vinod Koul <vkoul@kernel.org> wrote:
> On 30-08-19, 11:56, Randy Dunlap wrote:
> > On 8/30/19 11:52 AM, Michal Suchanek wrote:
> > > Fixes the following warning on !ACPI systems:
> > >
> > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > not used [-Wunused-function]
> > > static int sdw_slave_add(struct sdw_bus *bus,
> > > ^~~~~~~~~~~~~
> > >
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > I was about to send the same patch.
>
> So I have applied Srini's patches which add DT support and they use
> sdw_slave_add(). So next tomorrow should not see this error as it is now
> used by DT parts as well.
>
> So dropping this patch
>
That should fix the issue for me. I wonder if !ACPI !DT platforms are
still a thing.
Thanks
Michal
next prev parent reply other threads:[~2019-09-04 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:52 [PATCH] soundwire: slave: Fix unused function warning on !ACPI Michal Suchanek
2019-08-30 18:56 ` Randy Dunlap
2019-09-04 9:30 ` Vinod Koul
2019-09-04 10:48 ` Michal Suchánek [this message]
2019-09-04 11:40 ` Vinod Koul
2019-10-02 8:20 ` Michal Suchánek
2019-10-02 8:33 ` [PATCH 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-02 8:36 ` Greg KH
2019-10-02 8:33 ` [PATCH 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-02 8:36 ` Greg KH
2019-10-02 16:06 ` [alsa-devel] " Pierre-Louis Bossart
2019-10-03 10:15 ` Michal Suchánek
2019-10-03 10:13 ` [PATCH v2 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-15 10:45 ` Vinod Koul
2019-10-03 10:13 ` [PATCH v2 2/2] soundwire: depend on ACPI || OF Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904124803.1700a65a@naga \
--to=msuchanek@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox