Re: [PATCH -next 09/15] thermal: rockchip: use devm_platform_ioremap_resource() to simplify code

Heiko Stuebner
2019-10-04T21:50:18Z

Am Mittwoch, 4. September 2019, 14:29:33 CEST schrieb YueHaibing:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> drivers/thermal/rockchip_thermal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 343c2f5..044e6eb 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -1219,7 +1219,6 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct rockchip_thermal_data *thermal;
> const struct of_device_id *match;
> - struct resource *res;
> int irq;
> int i;
> int error;
> @@ -1245,8 +1244,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
> if (!thermal->chip)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - thermal->regs = devm_ioremap_resource(&pdev->dev, res);
> + thermal->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(thermal->regs))
> return PTR_ERR(thermal->regs);
>
>