From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier
Date: Wed, 4 Sep 2019 20:22:22 +0300 [thread overview]
Message-ID: <20190904172222.GV2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190904161051.GX5475@paasikivi.fi.intel.com>
On Wed, Sep 04, 2019 at 07:10:51PM +0300, Sakari Ailus wrote:
> On Mon, Sep 02, 2019 at 07:13:52PM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 02, 2019 at 04:57:32PM +0300, Sakari Ailus wrote:
> > > Add a test for the %pfw printk modifier using software nodes.
> >
> > > +static void __init fwnode_pointer(void)
> > > +{
> > > + const struct software_node softnodes[] = {
> > > + { .name = "first", },
> > > + { .name = "second", .parent = &softnodes[0], },
> > > + { .name = "third", .parent = &softnodes[1], },
> > > + { NULL /* Guardian */ },
> >
> > Comma is still here :-)
>
> Oops. I ended up removing the comma in a wrong patch which wasn't submitted
> to the list. Will fix for v6.
Also you may remove NULL there since it's default.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-04 17:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 13:57 [PATCH v5 00/11] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 01/11] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 02/11] software node: Make argument to to_software_node const Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 03/11] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 04/11] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 05/11] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-03 10:10 ` Heikki Krogerus
2019-09-03 11:24 ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 06/11] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 08/11] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-03 8:52 ` Petr Mladek
2019-09-03 9:28 ` Petr Mladek
2019-09-03 11:28 ` Andy Shevchenko
2019-09-06 7:04 ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-02 16:13 ` Andy Shevchenko
2019-09-04 16:10 ` Sakari Ailus
2019-09-04 17:22 ` Andy Shevchenko [this message]
2019-09-06 7:00 ` Sakari Ailus
2019-09-03 9:38 ` [PATCH v5 00/11] Device property improvements, add %pfw format specifier Joe Perches
2019-09-04 16:04 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904172222.GV2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox