From: Peter Zijlstra <peterz@infradead.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Jirka Hladký" <jhladky@redhat.com>,
"Jiří Vozár" <jvozar@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH 2/2] sched/debug: add sched_update_nr_running tracepoint
Date: Wed, 4 Sep 2019 19:48:41 +0200 [thread overview]
Message-ID: <20190904174841.GW2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190904143711.zorh2whdapymc5ng@e107158-lin.cambridge.arm.com>
On Wed, Sep 04, 2019 at 03:37:11PM +0100, Qais Yousef wrote:
> I managed to hook into sched_switch to get the nr_running of cfs tasks via
> eBPF.
>
> ```
> int on_switch(struct sched_switch_args *args) {
> struct task_struct *prev = (struct task_struct *)bpf_get_current_task();
> struct cgroup *prev_cgroup = prev->cgroups->subsys[cpuset_cgrp_id]->cgroup;
> const char *prev_cgroup_name = prev_cgroup->kn->name;
>
> if (prev_cgroup->kn->parent) {
> bpf_trace_printk("sched_switch_ext: nr_running=%d prev_cgroup=%s\\n",
> prev->se.cfs_rq->nr_running,
> prev_cgroup_name);
> } else {
> bpf_trace_printk("sched_switch_ext: nr_running=%d prev_cgroup=/\\n",
> prev->se.cfs_rq->nr_running);
> }
> return 0;
> };
> ```
>
> You can do something similar by attaching to the sched_switch tracepoint from
> a module and a create a new event to get the nr_running.
>
> Now this is not as accurate as your proposed new tracepoint in terms where you
> sample nr_running, but should be good enough?
The above is after deactivate() and gives an up-to-date count for
decrements. Attach something to trace_sched_wakeup() to get the
increment update.
next prev parent reply other threads:[~2019-09-04 17:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:43 [PATCH 0/2] sched/debug: add sched_update_nr_running tracepoint Radim Krčmář
2019-09-03 15:43 ` [PATCH 1/2] x86/mm/tlb: include tracepoints from tlb.c instead of mmu_context.h Radim Krčmář
2019-09-03 15:43 ` [PATCH 2/2] sched/debug: add sched_update_nr_running tracepoint Radim Krčmář
2019-09-03 16:05 ` Valentin Schneider
2019-09-04 4:23 ` Joel Fernandes
2019-09-04 8:14 ` Peter Zijlstra
2019-09-04 10:52 ` Qais Yousef
2019-09-04 13:11 ` Joel Fernandes
2019-09-04 15:26 ` Alexei Starovoitov
2019-09-04 15:33 ` Joel Fernandes
2019-09-04 15:37 ` Alexei Starovoitov
2019-09-04 15:41 ` Joel Fernandes
2019-09-04 10:43 ` Qais Yousef
2019-09-04 13:06 ` Joel Fernandes
2019-09-04 14:20 ` Qais Yousef
2019-09-04 14:41 ` Joel Fernandes
2019-09-04 14:57 ` Qais Yousef
2019-09-04 15:46 ` Joel Fernandes
2019-09-04 15:25 ` Alexei Starovoitov
2019-09-04 15:40 ` Joel Fernandes
2019-09-04 15:51 ` Alexei Starovoitov
2019-09-04 17:47 ` Peter Zijlstra
2019-09-04 17:53 ` Alexei Starovoitov
2019-09-05 8:13 ` Ingo Molnar
2019-09-05 16:49 ` Alexei Starovoitov
2019-09-04 6:55 ` chengjian (D)
2019-09-04 13:13 ` Peter Zijlstra
2019-09-04 13:21 ` Valentin Schneider
2019-09-04 14:37 ` Qais Yousef
2019-09-04 17:48 ` Peter Zijlstra [this message]
2019-09-09 10:59 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904174841.GW2332@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jhladky@redhat.com \
--cc=jvozar@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=qais.yousef@arm.com \
--cc=rkrcmar@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox