From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C78C3A5A8 for ; Wed, 4 Sep 2019 17:55:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3D5D22CEA for ; Wed, 4 Sep 2019 17:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567619744; bh=yr4ch9rwju2SqQkK8tFH0pysm3ex2mVPb9iB2D/7cMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AtV+Z+JHD8NgRQPRJCtfmRAsiy3aPrg1tHUlPLlzxCh4/B/AzaSTfykafJqTu8DE9 BlJk9XgOTUhfopf7BkCW6ry+MxFXpO6wbq6VL1mkWo5+o7KiP/033Fqk4PVuK5Racp HbCHxgi0nexVkW64q+I9ax0lrpirC/R1qK4S/slo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732861AbfIDRzn (ORCPT ); Wed, 4 Sep 2019 13:55:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:60840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732799AbfIDRzk (ORCPT ); Wed, 4 Sep 2019 13:55:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B045622CEA; Wed, 4 Sep 2019 17:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567619740; bh=yr4ch9rwju2SqQkK8tFH0pysm3ex2mVPb9iB2D/7cMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJsQUIXGUNKlXAsoGFA5pp6cmvL+XcmNg8z6FIahpm2xCdrGSl4+ZODN2aIw1c7dT h8CHr7GPmwD7HWh+Xx/4MwaWxihl+S9nXSpoK3zhP1uSH2CMIJxZUnNRexwYPeMVg9 zqfk0fV9oyF3kN2vyHaTijYJHuQJ2znF8e9mG79c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Willem de Bruijn , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 4.4 05/77] can: dev: call netif_carrier_off() in register_candev() Date: Wed, 4 Sep 2019 19:52:52 +0200 Message-Id: <20190904175303.919845972@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190904175303.317468926@linuxfoundation.org> References: <20190904175303.317468926@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c63845609c4700488e5eacd6ab4d06d5d420e5ef ] CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev trigger as suggested, there's a small inconsistency with the link property: The LED is on initially, stays on when the device is brought up, and then turns off (as expected) when the device is brought down. Make sure the LED always reflects the state of the CAN device. Signed-off-by: Rasmus Villemoes Acked-by: Willem de Bruijn Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 8b7c6425b681d..9dd968ee792e0 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -1065,6 +1065,8 @@ static struct rtnl_link_ops can_link_ops __read_mostly = { int register_candev(struct net_device *dev) { dev->rtnl_link_ops = &can_link_ops; + netif_carrier_off(dev); + return register_netdev(dev); } EXPORT_SYMBOL_GPL(register_candev); -- 2.20.1