Re: [PATCH V6 2/3] riscv: Add support for perf registers sampling

Paul Walmsley
2019-09-04T21:22:21Z

Hello Mao Han,

On Thu, 29 Aug 2019, Mao Han wrote:

> This patch implements the perf registers sampling and validation API
> for riscv arch. The valid registers and their register ID are defined in
> perf_regs.h. Perf tool can backtrace in userspace with unwind library
> and the registers/user stack dump support.

[ ... ]

> diff --git a/arch/riscv/include/uapi/asm/perf_regs.h b/arch/riscv/include/uapi/asm/perf_regs.h
> new file mode 100644
> index 0000000..df1a581
> --- /dev/null
> +++ b/arch/riscv/include/uapi/asm/perf_regs.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

All of the other Linux architectures use "GPL-2.0 WITH Linux-syscall-note"
for their license for the perf uapi files. Could you please change this
license string to match the standard Linux practice? Then I think it
should be good to merge.

- Paul