Re: [PATCH v3 0/4] PCI: Clean up pci-sysfs.c

Greg KH
2019-08-15T16:08:26Z

On Thu, Aug 15, 2019 at 09:33:49AM -0600, Kelsey Skunberg wrote:
> This series is designed to clean up device attributes and permissions in
> pci-sysfs.c. Then move the sysfs SR-IOV functions from pci-sysfs.c to
> iov.c for better organization.
>
> Patch 1: Define device attributes with DEVICE_ATTR* instead of __ATTR*.
>
> Patch 2: Change permissions from symbolic to the preferred octal.
>
> Patch 3: Change DEVICE_ATTR() with 0220 permissions to DEVICE_ATTR_WO().
>
> Patch 4: Move sysfs SR-IOV functions to iov.c to keep the feature's code
> together.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>