Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket

Andy Shevchenko
2019-09-06T13:47:00Z

On Fri, Sep 06, 2019 at 05:39:54AM -0400, Prarit Bhargava wrote:
> On 9/5/19 7:37 PM, Srinivas Pandruvada wrote:
> > Read the bucket and core count relationship via MSR and display
> > when displaying turbo ratio limits.

> > + ret = isst_send_msr_command(cpu, 0x1ae, 0, buckets_info);
>
> ^^^ you can get rid of the magic number 0x1ae by doing (sorry for the cut-and-paste)
>
> diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel
> index 12c6939dca2a..087d802ad844 100644
> --- a/tools/power/x86/intel-speed-select/Makefile
> +++ b/tools/power/x86/intel-speed-select/Makefile
> @@ -15,6 +15,8 @@ endif
> MAKEFLAGS += -r
>
> override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include

> +override CFLAGS += -I../../../include
> +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'

I guess it can be done in more neat way.

> As I've been looking at this code I have been wondering why didn't you just use
> the standard /dev/cpu/X/msr interface that other x86 power utilities (turbostat,
> x86_energy_perf_policy) use? Implementing msr_read() is trivial (warning
> untested and uncompiled code)

Actually good point!

--
With Best Regards,
Andy Shevchenko