From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A38C43331 for ; Fri, 6 Sep 2019 10:17:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E96E220674 for ; Fri, 6 Sep 2019 10:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390858AbfIFKRU (ORCPT ); Fri, 6 Sep 2019 06:17:20 -0400 Received: from mga07.intel.com ([134.134.136.100]:57055 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfIFKRT (ORCPT ); Fri, 6 Sep 2019 06:17:19 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 03:17:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="213103303" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 06 Sep 2019 03:17:17 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i6BIq-0004u8-QB; Fri, 06 Sep 2019 13:17:16 +0300 Date: Fri, 6 Sep 2019 13:17:16 +0300 From: Andy Shevchenko To: "J. Bruce Fields" Cc: linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH 6/9] Eliminate unused ESCAPE_NULL, ESCAPE_SPACE flags Message-ID: <20190906101716.GN2680@smile.fi.intel.com> References: <20190905193604.GC31247@fieldses.org> <1567712673-1629-1-git-send-email-bfields@redhat.com> <1567712673-1629-6-git-send-email-bfields@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567712673-1629-6-git-send-email-bfields@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 05, 2019 at 03:44:30PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > I can see how some finer-grained flags could be useful, but for now I'm > trying to simplify, so let's just remove these unused ones. > > Note the trickiest part is actually the tests, and I still need to check > them. Currently this _tries_ to follow the shorthand character classes which is established by tools. For example, "\s" = "[ \t\r\n\f]". Also it (almost?) matches the counterpart, i.e. string_unescape() classes. So, if we would need something else, perhaps better to do it in the separate flags. -- With Best Regards, Andy Shevchenko