From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <kernellwp@gmail.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [PATCH v4 3/4] KVM: VMX: Change ple_window type to unsigned int
Date: Fri, 6 Sep 2019 07:22:08 -0700 [thread overview]
Message-ID: <20190906142208.GA29496@linux.intel.com> (raw)
In-Reply-To: <20190906021722.2095-4-peterx@redhat.com>
On Fri, Sep 06, 2019 at 10:17:21AM +0800, Peter Xu wrote:
> The VMX ple_window is 32 bits wide, so logically it can overflow with
> an int. The module parameter is declared as unsigned int which is
> good, however the dynamic variable is not. Switching all the
> ple_window references to use unsigned int.
>
> The tracepoint changes will also affect SVM, but SVM is using an even
> smaller width (16 bits) so it's always fine.
>
> Suggested-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
next prev parent reply other threads:[~2019-09-06 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 2:17 [PATCH v4 0/4] KVM: X86: Some tracepoint enhancements Peter Xu
2019-09-06 2:17 ` [PATCH v4 1/4] KVM: X86: Trace vcpu_id for vmexit Peter Xu
2019-09-06 2:17 ` [PATCH v4 2/4] KVM: X86: Remove tailing newline for tracepoints Peter Xu
2019-09-06 2:17 ` [PATCH v4 3/4] KVM: VMX: Change ple_window type to unsigned int Peter Xu
2019-09-06 14:22 ` Sean Christopherson [this message]
2019-09-06 2:17 ` [PATCH v4 4/4] KVM: X86: Tune PLE Window tracepoint Peter Xu
2019-09-06 14:23 ` Sean Christopherson
2019-09-10 17:05 ` [PATCH v4 0/4] KVM: X86: Some tracepoint enhancements Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906142208.GA29496@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kernellwp@gmail.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox